aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoland Dreier <roland@purestorage.com>2011-05-02 22:15:37 -0700
committerNicholas Bellinger <nab@linux-iscsi.org>2011-07-22 09:37:43 +0000
commitf22c119683e73498d8126581a1be75e1b7a339a3 (patch)
treeef3fe19b414b04012a24419c2a9451ec6f255241
parente3d6f909ed803d92a5ac9b4a2c087e0eae9b90d0 (diff)
target: Fix double test of inquiry_prod
The code in transport_add_device_to_core_hba() really intends to make sure that neither inquiry_prod nor inquiry_rev is NULL. Signed-off-by: Roland Dreier <roland@purestorage.com> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
-rw-r--r--drivers/target/target_core_transport.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index e4406c9e66e..6f5d4dfa14e 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1623,7 +1623,7 @@ struct se_device *transport_add_device_to_core_hba(
* setup.
*/
if (dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV) {
- if (!(inquiry_prod) || !(inquiry_prod)) {
+ if (!inquiry_prod || !inquiry_rev) {
printk(KERN_ERR "All non TCM/pSCSI plugins require"
" INQUIRY consts\n");
goto out;