dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

[Patch] fs/binfmt_elf.c: fix a wrong free 

In kmalloc failing path, we shouldn't free pointers in 'info',
because the struct 'info' is uninitilized when kmalloc is called.

And when kmalloc returns NULL, it's needless to kfree it.

Signed-off-by: WANG Cong <wangcong@zeuux.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>

--
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
WANG Cong 2008-05-06 12:45:35 +08:00 committed by Al Viro
parent eceea0b3df
commit 5f719558ed
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/binfmt_elf.c
View File

@ -1900,7 +1900,7 @@ static int elf_core_dump(long signr, struct pt_regs *regs, struct file *file, un
/* alloc memory for large data structures: too large to be on stack */
elf = kmalloc(sizeof(*elf), GFP_KERNEL);
if (!elf)
goto cleanup;
goto out;
segs = current->mm->map_count;
#ifdef ELF_CORE_EXTRA_PHDRS
@ -2034,8 +2034,9 @@ end_coredump:
set_fs(fs);
cleanup:
kfree(elf);
free_note_info(&info);
kfree(elf);
out:
return has_dumped;
}