dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

hwmon: (adt7410) handle errors from adt7410_update_device() 

Smatch complains that adt7410_update_device() can return error pointers.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Dan Carpenter 2012-08-15 10:49:43 +03:00 committed by Guenter Roeck
parent 983b97bed2
commit 37f9648b27
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/hwmon/adt7410.c
View File

@ -236,9 +236,14 @@ static ssize_t adt7410_show_t_hyst(struct device *dev,
char *buf)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
struct adt7410_data *data = adt7410_update_device(dev);
struct adt7410_data *data;
int nr = attr->index;
int hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000;
int hyst;
data = adt7410_update_device(dev);
if (IS_ERR(data))
return PTR_ERR(data);
hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000;
/*
* hysteresis is stored as a 4 bit offset in the device, convert it