aboutsummaryrefslogtreecommitdiffstats
path: root/nametoaddr.c
diff options
context:
space:
mode:
authorguy <guy>2000-12-18 03:45:34 +0000
committerguy <guy>2000-12-18 03:45:34 +0000
commit892c4a44362b71124fa59dbf4f723a661c27517f (patch)
treed5d522bc1f31c9a543f696fb67d73a4f6e24c4c7 /nametoaddr.c
parent839690365fd1d37532237c31c8cab18c995604f7 (diff)
Put in a comment noting that we should, perhaps, declare
"ether_hostton()" in "lbl/os-XXX.h" files rather than in "nametoaddr.c".
Diffstat (limited to 'nametoaddr.c')
-rw-r--r--nametoaddr.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/nametoaddr.c b/nametoaddr.c
index e4b596d..c30c228 100644
--- a/nametoaddr.c
+++ b/nametoaddr.c
@@ -24,7 +24,7 @@
#ifndef lint
static const char rcsid[] =
- "@(#) $Header: /tcpdump/master/libpcap/nametoaddr.c,v 1.56 2000-12-18 03:42:39 guy Exp $ (LBL)";
+ "@(#) $Header: /tcpdump/master/libpcap/nametoaddr.c,v 1.57 2000-12-18 03:45:34 guy Exp $ (LBL)";
#endif
#ifdef HAVE_CONFIG_H
@@ -355,6 +355,15 @@ pcap_ether_hostton(const char *name)
}
#else
+/*
+ * XXX - perhaps this should, instead, be declared in "lbl/os-XXX.h" files,
+ * for those OS versions that don't declare it, rather than being declared
+ * here? That way, for example, we could declare it on FreeBSD 2.x (which
+ * doesn't declare it), but not on FreeBSD 3.x (which declares it like
+ * this) or FreeBSD 4.x (which declares it with its first argument as
+ * "const char *", so no matter how we declare it here, it'll fail to
+ * compile on one of 3.x or 4.x).
+ */
#if !defined(sgi) && !defined(__NetBSD__) && !defined(__FreeBSD__)
extern int ether_hostton(char *, struct ether_addr *);
#endif