From f5c39a33b733cfc8510a6909fbd2a0bb1126237b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dr=2E=20Lars=20V=C3=B6lker?= Date: Thu, 19 Mar 2020 19:10:41 +0100 Subject: SOMEIP: SD did not register port for IPv6 correctly (bugfix) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SOME/IP-SD did not register a port learned correctly, so that packets with this port number were not dissected. Bug: 16448 Change-Id: Ic648a50bf08dcab65c49182e08257cf6660261a5 Signed-off-by: Dr. Lars Völker Reviewed-on: https://code.wireshark.org/review/36503 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin --- epan/dissectors/packet-someip-sd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/epan/dissectors/packet-someip-sd.c b/epan/dissectors/packet-someip-sd.c index 4e8b278799..c32d0ef26c 100644 --- a/epan/dissectors/packet-someip-sd.c +++ b/epan/dissectors/packet-someip-sd.c @@ -1,7 +1,8 @@ /* packet-someip.c * SOME/IP-SD dissector. - * By Dr. Lars Voelker / - * Copyright 2012-2019 Dr. Lars Voelker + * By Dr. Lars Voelker / + * Copyright 2012-2020 Dr. Lars Voelker + * Copyright 2020 Ayoub Kaanich * Copyright 2019 Ana Pantar * Copyright 2019 Guenter Ebermann * @@ -360,7 +361,7 @@ dissect_someip_sd_pdu_option_ipv6(tvbuff_t *tvb, packet_info *pinfo, proto_tree } offset += 1; - proto_tree_add_item(tree, hf_someip_sd_option_port, tvb, offset, 2, ENC_BIG_ENDIAN); + proto_tree_add_item_ret_uint(tree, hf_someip_sd_option_port, tvb, offset, 2, ENC_BIG_ENDIAN, &l4port); proto_item_append_text(ti_top, " (%s)", l4protoname); -- cgit v1.2.3