From 9979de35e6d607a6ea713ae97a57fc6c00666803 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Wed, 2 Jan 2019 15:55:51 -0800 Subject: Don't fall out of the loop on a write error. Doing so means we'd close the FD, but we've already closed it. Addresses Coverity CID 1442274. Change-Id: I5aab1bd4b82e9ac0901bcdbc1ddb6b16eec30573 Reviewed-on: https://code.wireshark.org/review/31312 Reviewed-by: Guy Harris --- ui/export_object_ui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/export_object_ui.c b/ui/export_object_ui.c index 67ec18eb4d..750e432db9 100644 --- a/ui/export_object_ui.c +++ b/ui/export_object_ui.c @@ -72,7 +72,7 @@ eo_save_entry(const gchar *save_as_filename, export_object_entry_t *entry) err = WTAP_ERR_SHORT_WRITE; report_write_failure(save_as_filename, err); ws_close(to_fd); - break; + return; } bytes_left -= bytes_written; ptr += bytes_written; -- cgit v1.2.3