From 1ccb0b7a8e9f0e063558e5be58f1c90a3c2842c5 Mon Sep 17 00:00:00 2001 From: Alexis La Goutte Date: Thu, 3 Jan 2019 09:53:25 +0000 Subject: geonw: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ib1e26cc20ad30889a56455bcf529ba404f14506f Reviewed-on: https://code.wireshark.org/review/31320 Reviewed-by: Anders Broman --- epan/dissectors/packet-geonw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/epan/dissectors/packet-geonw.c b/epan/dissectors/packet-geonw.c index baca366197..9aba16b4fe 100644 --- a/epan/dissectors/packet-geonw.c +++ b/epan/dissectors/packet-geonw.c @@ -611,7 +611,7 @@ geonw_addr_resolve(hashgeonw_t *tp) { l2 = (guint8) g_strlcpy(rname, string, MAXNAMELEN-l1-3); } rname += l2; - l1 += l2; + //l1 += l2; *rname++ = '.'; // LL_ADDR set_address(ð_addr, AT_ETHER, 6, &(addr[2])); @@ -1978,7 +1978,7 @@ dissect_secured_message(tvbuff_t *tvb, gint offset, packet_info *pinfo, proto_tr return tvb_captured_length(tvb); } - ti = proto_tree_add_item(secmsg_tree, hf_sgeonw_version, tvb, offset, 1, ENC_BIG_ENDIAN); + proto_tree_add_item(secmsg_tree, hf_sgeonw_version, tvb, offset, 1, ENC_BIG_ENDIAN); offset+=1; if ((version < 1) || (version > 2)) return 1; @@ -2478,7 +2478,7 @@ dissect_geonw(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U proto_tree_add_item(geonw_so_add_tree, hf_geonw_so_pv_addr_mid, tvb, offset, 6, ENC_NA); offset += 6; - ti = proto_tree_add_item_ret_uint(geonw_so_tree, hf_geonw_so_pv_time, tvb, offset, 4, ENC_BIG_ENDIAN, ×tamp); + proto_tree_add_item_ret_uint(geonw_so_tree, hf_geonw_so_pv_time, tvb, offset, 4, ENC_BIG_ENDIAN, ×tamp); geonwh->gnw_tst = timestamp; // XXX Is it possible to "follow" a station when updating its GN_ADDR? -- cgit v1.2.3