From 17647c4041cfe05dbd5e08d68662007b1e8e4146 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Mon, 14 May 2018 12:26:33 +0200 Subject: fip: avoid tvb_bytes_exist with negative length This will no longer be a valid way to check for remaining data. Change-Id: I5533b8efc3344f0f8e28d873e5363256a014ab05 Reviewed-on: https://code.wireshark.org/review/27525 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- epan/dissectors/packet-fip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epan/dissectors/packet-fip.c b/epan/dissectors/packet-fip.c index 2cdb5f3ccb..34e9760db8 100644 --- a/epan/dissectors/packet-fip.c +++ b/epan/dissectors/packet-fip.c @@ -509,7 +509,7 @@ dissect_fip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_) subtree = fip_desc_type_len(fip_tree, desc_tvb, dtype, ett_fip_dt_vend, &item); proto_tree_add_item(subtree, hf_fip_desc_vend, desc_tvb, 4, 8, ENC_NA); - if (tvb_bytes_exist(desc_tvb, 9, -1)) { + if (tvb_reported_length_remaining(desc_tvb, 9)) { proto_tree_add_item(subtree, hf_fip_desc_vend_data, desc_tvb, 9, -1, ENC_NA); } -- cgit v1.2.3