aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-07-10Qt: add assert (CID 1311486).Dario Lombardo1-1/+2
Change-Id: I62290f1f1c7856ee431705a64fae2022b850234a Reviewed-on: https://code.wireshark.org/review/16361 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-09randpkt_core: change rand() to g_rand_int (CID 1355360).Dario Lombardo4-72/+20
Change-Id: I48560cbb6007eb16aa545a3e8e6a0e8e3b206930 Reviewed-on: https://code.wireshark.org/review/16326 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-09IPv6: Remove obsolete commentJoão Valverde1-3/+0
WS_INET6_ADDRSTRLEN should be used instead of INET6_ADDRSTRLEN. Change-Id: Id937ca72361f4f1b3cad2c18b1067c3fddc527a9 Reviewed-on: https://code.wireshark.org/review/16359 Reviewed-by: João Valverde <j@v6e.pt>
2016-07-09packet-wsp.c: Fix infinite loop in add_headersMichael Mann1-0/+15
Bug: 12594 Change-Id: Id86d1e5f2db12871bc1b345721e79e57192f01e1 Reviewed-on: https://code.wireshark.org/review/16355 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-09Fix detection of NSIS/WiX install path when running a win64 CMakePascal Quantin2-4/+7
On x86 system: System32\cmd.exe ProgramFiles=C:\Program Files On x64 system: System32\cmd.exe ProgramFiles=C:\Program Files ProgramFiles(x86)=C:\Program Files (x86) ProgramW6432=C:\Program Files Syswow64\cmd.exe ProgramFiles=C:\Program Files (x86) ProgramFiles(x86)=C:\Program Files (x86) ProgramW6432=C:\Program Files Change-Id: I32d52219366b299f1e8099dc6d7737970dc398dd Reviewed-on: https://code.wireshark.org/review/16346 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-09Check for pcapng files when reading from a pipe.Guy Harris1-22/+29
That way, people don't get confused by an "Unrecognized libpcap format" error - it's *not* libpcap format! Also, improve *that* message to say "...or not libpcap data", and put a period at the end of the error messages. Change-Id: I175f9399fe99ce424f1d83596b7330e1fa5c0625 Reviewed-on: https://code.wireshark.org/review/16349 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-08Fix value_string_ext_free() constnessJoão Valverde2-3/+3
Don't declare destructor as taking a const argument. Change-Id: I9badfe400718bef41a0e0a00d4b3d1b0bb2879d1 Reviewed-on: https://code.wireshark.org/review/16342 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-08IPv6: Remove a memcpy()João Valverde1-16/+14
Replace CamelCase and remove unnecessary casts too. Change-Id: Iacf56912448c0e0dc0fe21477d6b71ba9caba69a Reviewed-on: https://code.wireshark.org/review/16344 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-08fixed some juniper vn dissector bugsAmitoj Setia1-8/+8
Change-Id: I67ea5df962266c1476d1d1b6234e831018138422 Reviewed-on: https://code.wireshark.org/review/16341 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-08GSM RLC/MAC: register dissectors for EC-GSM-IoT control messagesPascal Quantin1-0/+22
Change-Id: I8fe84cc98b8967c529c07ff17014648610ad8660 Reviewed-on: https://code.wireshark.org/review/16340 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-08MAC LTE: upgrade dissector to v13.2.0Pascal Quantin2-24/+159
Change-Id: Ic859d69583ca3c342d4775511b68fc276f3290a4 Reviewed-on: https://code.wireshark.org/review/16339 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-08When generating the LUA reference in AsciiDoc then say so.Jaap Keuter1-4/+4
Generating LUA documentation source for the developer guide says that it's generating XML, which it did before the switch to AsciiDoc. Fix this statement. Change-Id: Ib8625af84c74b5f6dc31c1e9e5ded80d9d7940ff Reviewed-on: https://code.wireshark.org/review/16320 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-08couchbase: Fix Dead Store (Dead assignement/Dead increment) Warning found by ↵Alexis La Goutte1-1/+0
Clang Change-Id: Ie1e3b071388b3527bba1088af69d76dcb8d6981a Reviewed-on: https://code.wireshark.org/review/16333 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-08APRS: more cleanup.Jeff Morriss1-245/+75
There's no need to create global structures with pointers to the (global) hf's to pass into the dissection functions. Just reference the global variables directly. Remove other global variables passed as arguments while we're at it. Remove boilerplate comments. Change-Id: I7ce6b356172aa25983f4cc6a007a0158cb7f26c9 Reviewed-on: https://code.wireshark.org/review/16331 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-08APRS: clean up some header fields.Jeff Morriss1-22/+22
Try to make the names self-explanatory (without relying on blurbs). Change-Id: Icfb4797282987b42ac68709b431d8b7248a0a633 Reviewed-on: https://code.wireshark.org/review/16330 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-08Qt: Update scrollbars when change byte view formatStig Bjørlykke1-0/+1
Update scrollbars when changing display format between hex and bits view because the height of the phane will change. Change-Id: I81556c8dbdfb0a34f6c97e76834646a40aed62bb Reviewed-on: https://code.wireshark.org/review/16336 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-07-08ZigBee GreenPower: Fix GP Pairing command dissection.dsrsupport1-1/+1
Fix length of Sink GroupID in GP Pairing command. Change-Id: I5905812456faa0181ee1cc13824a12ce2583d4e0 Reviewed-on: https://code.wireshark.org/review/16335 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-07-08p1: Add BuiltInEncodedInformationTypes.telexStig Bjørlykke2-1/+7
This is for completeness. Change-Id: Id89f649aa836dd011f0967cdbdc905916b4d2182 Reviewed-on: https://code.wireshark.org/review/16334 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-07-08nbifom: fix no previous prototype for 'proto_register_nbifom' ↵Alexis La Goutte1-0/+2
[-Wmissing-prototypes] Change-Id: I4456cfd6600986b2e0c1cecf7d3054f3e829a210 Reviewed-on: https://code.wireshark.org/review/16332 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-08Qt: add initializers (CID 1261463).Dario Lombardo1-0/+5
Change-Id: I5c2d5c73e188586a91dde342d6347d25495e0263 Reviewed-on: https://code.wireshark.org/review/16325 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-08Qt: add initializer (CID 1269610).Dario Lombardo1-1/+1
Change-Id: I483e5d3f239f4708f9fc6b11c98869bb1381fb44 Reviewed-on: https://code.wireshark.org/review/16324 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-08Qt: add initializers (CID 1317257).Dario Lombardo1-2/+12
Change-Id: I61a63c187990b119b62e99871832913a0e3f75e4 Reviewed-on: https://code.wireshark.org/review/16323 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-08Handle extcap binaries and the libssh upon which some depend.Guy Harris1-0/+8
Search the extcap binaries for shared libraries they require. Treat libssh specially - for some reason, when built by macosx-setup.sh (which just does a standard cmake build of libssh), libssh's shared library has just libssh.4.dylib, not {installation directory}/libssh.4.dylib, as its shared library ID, so we don't find its binary using otool -L. Bug: 12471 Change-Id: I3e5632d7520f1bbeca1a8faae3a012938ef9dee7 Reviewed-on: https://code.wireshark.org/review/16329 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-08osx-app.sh: add ciscodump.Dario Lombardo1-0/+4
Ping-Bug: 12471 Change-Id: I7326e43ce8b294c8065e09120d85b4743f1659a9 Reviewed-on: https://code.wireshark.org/review/16321 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-07Clean up fixed field handlingJoerg Mayer1-828/+555
- Get rid of FF_FIELD macro. Use resoved strings instead. - Reorder add_ff_ functions so we don't need forward declarations - Replace add_fixed_field call by call to resolved function - Remove add_fixed_field and all structs and enums exclusive to it. - #if 0 out unused function add_ff_relay_capable_sta_info Change-Id: I9955febb317f3e7c1b9ae28a5ee9c6a6472f7e9c Reviewed-on: https://code.wireshark.org/review/16328 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-07-07CMakeLists.txt: Fix gcee3e82João Valverde1-1/+1
Bug: 12589 Change-Id: I7f9be4027214cb7ae4f7b235cba73c088596a80d Reviewed-on: https://code.wireshark.org/review/16322 Reviewed-by: João Valverde <j@v6e.pt>
2016-07-07APRS: register the storm fields.Jeff Morriss1-39/+57
There's been a comment here since 2012 about them being unregistered. Put in some registrations based on a feeble understanding of the specification (these are all strings, add them as such); that should be close enough and is much better than the (dissector) assertion we'd get otherwise. Don't bother putting those hf's in a global structure and passing around the structure: the hf's are global anyway--just reference them directly. Add a link to the specification while we're here. Change-Id: Ia7b17e92a996a1a8eb4a4489eff9fca042190a32 Reviewed-on: https://code.wireshark.org/review/16318 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-07PAPI: Update Header fieldAlexis La Goutte1-33/+57
Change-Id: I0c2a522ea70e62b6962c99729068e962beb21085 Reviewed-on: https://code.wireshark.org/review/15572 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-06openSAFETY: Simplify handling of SN Fail/AckRoland Knall1-47/+61
Also add information about error group/code acknowledged, and additional parameter set missing, if applicable Change-Id: I911d9941a33ff4064649090908e0fcc2bf6e00f8 Reviewed-on: https://code.wireshark.org/review/16319 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-07-06configure: Check for working lreleaseJoão Valverde2-1/+14
The qtchooser package in many (all?) distros installs executable symlinks to qtchooser that can mislead AC_PROG_PATH if the corresponding Qt linguist tools package is missing. Bug: 12570 Change-Id: I98795a3a7b8a05214c56a0c7b50829ea3b2976fa Reviewed-on: https://code.wireshark.org/review/16316 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Adrian Simionov <daniel.simionov@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
2016-07-06ATM PW: don't use macros to generate hf entries.Jeff Morriss1-20/+27
The macros weren't saving much code, were confusing checkhf.pl, and were hiding useability problems with the fields (such as names equal to the abbreviation and having several fields with the same abbreviation--things checkAPIs.pl can check now that the macros are out of the way). Change-Id: Id2ba67d09ce7dd424aee9d7f2e25eb54fa432d98 Reviewed-on: https://code.wireshark.org/review/16315 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-06LAT: use ENC_ASCII when adding strings.Jeff Morriss1-10/+10
Change-Id: If3970fbc25d4085037fb975498de02449e2c25c1 Reviewed-on: https://code.wireshark.org/review/16317 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-06LAT: register several hf's.Jeff Morriss1-0/+16
Found by checkhf.pl Change-Id: If985d04f24a188ac402bc11cf61d29aa418ad242 Reviewed-on: https://code.wireshark.org/review/16314 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-06DIS: Introduced support of Collision PDUHendrik Uhlmann1-0/+95
Parse all Attributes of Collision PDU and display them in wireshark HMI. Change-Id: I3003c6dd709498cc6c1adf784800047d0984bafa Reviewed-on: https://code.wireshark.org/review/16299 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-07-06Qt: add initializers (CID 1268205).Dario Lombardo1-10/+10
Change-Id: I7eb71876731df29c076a3a756b6748f165d1c327 Reviewed-on: https://code.wireshark.org/review/16306 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-06Qt: add initializers (CID 1162824).Dario Lombardo3-1/+22
Change-Id: Ib570d3531bfdd35404b75d49dbd7dd43db4c30d9 Reviewed-on: https://code.wireshark.org/review/16310 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-06packet-couchbase.c: describe observe-seqno (0x91)Sergey Avseyev1-2/+70
Change-Id: I6018a57a8ae947ee68aa35901398d504d35b99c7 Reviewed-on: https://code.wireshark.org/review/16312 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-07-06Qt: remove unneeded constructors.Dario Lombardo2-9/+0
There is no need to have an empty private constructor if an explicit one is already present. The former private constructor didn't initialize the private members causing many CIDs from coverity. Change-Id: I8ba98d2b9fc32a867fdcf3421df7946b90bd7b09 Reviewed-on: https://code.wireshark.org/review/16311 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-05Rename PIDL MakefileJoão Valverde3-2/+1
Otherwise it will get overwritten by the in-tree cmake build. Issue reported by Rémy Léone. Change-Id: I0d908973386bcb70585f5e32c36456230967bb7f Reviewed-on: https://code.wireshark.org/review/16305 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-05Qt: remove unused variable.Dario Lombardo1-1/+0
This fixes also CID 1159350. Change-Id: I21b55686f96131e3e1cff0feac5f16df1c7c7ca2 Reviewed-on: https://code.wireshark.org/review/16309 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-05bgp: add return check (CID 1354417).Dario Lombardo1-2/+3
Change-Id: Id8be1d5f6346686087d747167ec44df2b88dd35e Reviewed-on: https://code.wireshark.org/review/16304 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-07-05tap: check return value (CID 1355643).Dario Lombardo1-1/+3
Change-Id: I03b141c7aeaa1bc06dc126c5cc8f0d001a57c116 Reviewed-on: https://code.wireshark.org/review/16302 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-05Qt: remove unused variable.Dario Lombardo1-1/+0
This fixes CID 1232347. Change-Id: I42b5ac997dbde8fcb05665b24444a60b009871be Reviewed-on: https://code.wireshark.org/review/16290 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-05Developers Guide updatesGraham Bloice2-9/+31
Added info about debugging under Visual Studio. Updated buildbot info. Change-Id: I9a6a0a2b14e3616a35f652c99b04ee23ea642ba5 Reviewed-on: https://code.wireshark.org/review/16307 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2016-07-05Remove remnants of g_spawn_helper supportPascal Quantin2-16/+0
Change-Id: I88121a280ff01a889daeda438b308380b6ea0703 Reviewed-on: https://code.wireshark.org/review/16303 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-05openSAFETY: Add byte offset of frameRoland Knall2-0/+10
Add the absolute byte offset of each openSAFETY frame to dissection, so a change in the offset can be easily detected Change-Id: Ib935eff7ba1e2e1169cb9071a5c9703cc58fc123 Reviewed-on: https://code.wireshark.org/review/16301 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-07-05Qt: add initializers (CID 1233100).Dario Lombardo1-1/+1
Change-Id: I99e0d6bd10cc0faddb8a503ec877b3d03b927f4e Reviewed-on: https://code.wireshark.org/review/16293 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-05Qt: add initializers (CID 1249475).Dario Lombardo1-1/+5
Change-Id: Ic001c0dfab1e82c66473d6ca15633aaa57520659 Reviewed-on: https://code.wireshark.org/review/16294 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-05dis: cast to guint64 to avoid potential overflow (CID 1214480).Dario Lombardo1-1/+1
Change-Id: I24ae4a7a5ef8b4ed363ec849ac9c8aeeefe836dd Reviewed-on: https://code.wireshark.org/review/16288 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-05extcap: Remove g_spawn_helper supportRoland Knall10-146/+503
Move g_spawn to separate file and implement functions to use Windows based method of spawning, instead of the glib based version Change-Id: Ibae03d834ec86531eba37dc8768fbf17ddadf57f Reviewed-on: https://code.wireshark.org/review/16049 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Roland Knall <rknall@gmail.com>