smalltalk
/
osmo-st-smpp
Archived
1
0
Fork 0
Code Releases Activity

codec: Refer to the right variable name 

Too much tab completion for the other project I spend time with
This commit is contained in:
Holger Hans Peter Freyther 2014-06-17 19:02:08 +02:00
parent eacd66d90a
commit ca7c90b83f
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
codec/SMPPBindTransmitterBody.st
View File

@ -17,7 +17,7 @@
" "
SMPPBodyBase subclass: SMPPBindTransmitterBody [ SMPPBodyBase subclass: SMPPBindTransmitterBody [
| systemd_id password system_type version addr_ton addr_npi addr_range | | system_id password system_type version addr_ton addr_npi addr_range |
SMPPBindTransmitterBody class >> messageType [ SMPPBindTransmitterBody class >> messageType [
^self bindTransmitter ^self bindTransmitter
@ -25,7 +25,7 @@ SMPPBodyBase subclass: SMPPBindTransmitterBody [
SMPPBindTransmitterBody class >> tlvDescription [ SMPPBindTransmitterBody class >> tlvDescription [
^OrderedCollection new ^OrderedCollection new
add: SMPPSystemdId tlvDescription; add: SMPPSystemId tlvDescription;
add: SMPPPassword tlvDescription; add: SMPPPassword tlvDescription;
add: SMPPSystemType tlvDescription; add: SMPPSystemType tlvDescription;
add: SMPPInterfaceVersion tlvDescription; add: SMPPInterfaceVersion tlvDescription;
@ -35,8 +35,8 @@ SMPPBodyBase subclass: SMPPBindTransmitterBody [
yourself yourself
] ]
systemdId [ systemId [
^systemd_id ^system_id
] ]
password [ password [
@ -64,7 +64,7 @@ SMPPBodyBase subclass: SMPPBindTransmitterBody [
] ]
systemId: anId [ systemId: anId [
systemd_id := anId system_id := anId
] ]
password: aPassword [ password: aPassword [

6
codec/attributes/SMPPSystemId.st
View File

@ -16,12 +16,12 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. along with this program. If not, see <http://www.gnu.org/licenses/>.
" "
SMPPOctetString subclass: SMPPSystemdId [ SMPPOctetString subclass: SMPPSystemId [
<comment: 'I re-present 5.2.1 of SMPPv3.4'> <comment: 'I re-present 5.2.1 of SMPPv3.4'>
SMPPSystemdId class >> tlvDescription [ SMPPSystemId class >> tlvDescription [
^super tlvDescription ^super tlvDescription
instVarName: #systemd_id; instVarName: #system_id;
minSize: 0 maxSize: 16; minSize: 0 maxSize: 16;
yourself yourself
] ]

4
test/SMPPMessageTest.st
View File

@ -75,7 +75,7 @@ TestCase subclass: SMPPMessageTest [
self assert: msg header commandStatus equals: 0. self assert: msg header commandStatus equals: 0.
self assert: msg header sequenceNumber equals: 1. self assert: msg header sequenceNumber equals: 1.
self assert: msg body systemdId equals: 'SMPP3TEST'. self assert: msg body systemId equals: 'SMPP3TEST'.
self assert: msg body password equals: 'secret08'. self assert: msg body password equals: 'secret08'.
self assert: msg body systemType equals: 'SUBMIT1'. self assert: msg body systemType equals: 'SUBMIT1'.
self assert: msg body version equals: 0. self assert: msg body version equals: 0.
@ -108,7 +108,7 @@ TestCase subclass: SMPPMessageTest [
| msg | | msg |
msg := SMPPMessage readFrom: self exampleBind readStream. msg := SMPPMessage readFrom: self exampleBind readStream.
self assert: msg body class equals: SMPPBindTransceiver. self assert: msg body class equals: SMPPBindTransceiver.
self assert: msg body systemdId equals: 'AAAAAAAAAA'. self assert: msg body systemId equals: 'AAAAAAAAAA'.
] ]
testEnquireLink [ testEnquireLink [