smalltalk
/
osmo-st-sip
Archived
1
0
Fork 0
Code Releases Activity

tests: Modernize and use >>#assert:equals 

Modernize the tests to use the >>#assert:equals: protocol as
this allows creating/finding failing tests earlier.
This commit is contained in:
Holger Hans Peter Freyther 2015-07-24 12:09:32 +02:00
parent 2abc6e82e5
commit d00bcc74a4
2 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
callagent/tests/SIPParserTest.st
View File

@ -98,25 +98,25 @@ PP.PPCompositeParserTest subclass: SIPParserTest [
| res |
res := self parse: self testOPTIONSRequestData.
self assert: res asDatagram = self testOPTIONSRequestData.
self assert: res asDatagram equals: self testOPTIONSRequestData.
]
testResponse [
| res |
res := self parse: self testResponseData.
self assert: res asDatagram = self testResponseData.
self assert: (res parameter: 'Via') branch = 'z9hG4bKMzQ4NTQzNDgxNCwyNDE1Nw__'.
self assert: (res parameter: 'CSeq') number = 1.
self assert: (res parameter: 'CSeq') method = 'INVITE'.
self assert: (res parameter: 'To') tag = '42eBv22Fj314N'.
self assert: (res parameter: 'To') address = 'sip:9198@172.16.1.72'.
self assert: ((res parameter: 'To') valueAt: 'abc') = 'def'.
self assert: ((res parameter: 'To') valueAt: 'kbc') = nil.
self assert: ((res parameter: 'To') valueAt: 'ajk') = nil.
self assert: res asDatagram equals: self testResponseData.
self assert: (res parameter: 'Via') branch equals: 'z9hG4bKMzQ4NTQzNDgxNCwyNDE1Nw__'.
self assert: (res parameter: 'CSeq') number equals: 1.
self assert: (res parameter: 'CSeq') method equals: 'INVITE'.
self assert: (res parameter: 'To') tag equals: '42eBv22Fj314N'.
self assert: (res parameter: 'To') address equals: 'sip:9198@172.16.1.72'.
self assert: ((res parameter: 'To') valueAt: 'abc') equals: 'def'.
self assert: ((res parameter: 'To') valueAt: 'kbc') equals: nil.
self assert: ((res parameter: 'To') valueAt: 'ajk') equals: nil.
self should: [((res parameter: 'To') valueAt: 'foo')] raise: SystemExceptions.NotFound.
self assert: (res parameter: 'From') tag = 'MzQ4NTQ0MTg2NzIyNDEwNjkyNjY_'.
self assert: (res parameter: 'From') address = 'sip:1000@on-waves.com'.
self assert: (res parameter: 'From') tag equals: 'MzQ4NTQ0MTg2NzIyNDEwNjkyNjY_'.
self assert: (res parameter: 'From') address equals: 'sip:1000@on-waves.com'.
self assert: res asDatagram equals: self testResponseData.
]
@ -124,12 +124,12 @@ PP.PPCompositeParserTest subclass: SIPParserTest [
| dialog |
dialog := SIPDialog fromMessage: (self parse: self testResponseData).
self
assert: dialog to = 'sip:9198@172.16.1.72';
assert: dialog to_tag = '42eBv22Fj314N';
assert: dialog from = 'sip:1000@on-waves.com';
assert: dialog from_tag = 'MzQ4NTQ0MTg2NzIyNDEwNjkyNjY_';
assert: dialog callId = 'MzY3NzE3ODgyNw__@xiaoyu';
assert: dialog cseq = 1.
assert: dialog to equals: 'sip:9198@172.16.1.72';
assert: dialog to_tag equals: '42eBv22Fj314N';
assert: dialog from equals: 'sip:1000@on-waves.com';
assert: dialog from_tag equals: 'MzQ4NTQ0MTg2NzIyNDEwNjkyNjY_';
assert: dialog callId equals: 'MzY3NzE3ODgyNw__@xiaoyu';
assert: dialog cseq equals: 1.
]
testDialogCompatible [
@ -156,9 +156,9 @@ PP.PPCompositeParserTest subclass: SIPParserTest [
res := SIPParser parse: self testByeRequestData.
self
assert: (res parameter: 'Allow' ifAbsent: []) = 'INVITE, ACK, BYE, CANCEL, OPTIONS, MESSAGE, UPDATE, INFO, REGISTER, REFER, NOTIFY, PUBLISH, SUBSCRIBE';
assert: (res parameter: 'Via' ifAbsent: []) branch = 'z9hG4bKvt9FDU96c89cQ';
assert: (res parameter: 'CSeq' ifAbsent: []) number = 14600327.
assert: (res parameter: 'Allow' ifAbsent: []) equals: 'INVITE, ACK, BYE, CANCEL, OPTIONS, MESSAGE, UPDATE, INFO, REGISTER, REFER, NOTIFY, PUBLISH, SUBSCRIBE';
assert: (res parameter: 'Via' ifAbsent: []) branch equals: 'z9hG4bKvt9FDU96c89cQ';
assert: (res parameter: 'CSeq' ifAbsent: []) number equals: 14600327.
]
statusResponseData [

6
callagent/tests/Tests.st
View File

@ -35,7 +35,7 @@ TestCase subclass: SIPRequestTest [
nextPutAll: 'Contact: <sip:1000@on-foo.com>'; cr; nl;
cr; nl; contents.
self assert: req asDatagram = out.
self assert: req asDatagram equals: out.
]
testOPTIONS [
@ -92,7 +92,7 @@ TestCase subclass: SIPUdpTransportTest [
onTimeoutDo: [].
self deny: read data isNil.
self assert: read size = 5.
self assert: (read data copyFrom: 1 to: 5) = 'foooo' asByteArray.
self assert: read size equals: 5.
self assert: (read data copyFrom: 1 to: 5) equals: 'foooo' asByteArray.
]
]