From 4a3fa71d9da5d70409cf3eabe332c9f5c673b54e Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 19 Aug 2020 08:57:33 +0200 Subject: msc: Make TC_lu_and_mo_call_sccp_tiar_timeout() more reliable There is a race condition when shutting down, as a DLCX might arrive while we are half-shutdown. Expect both DLCX before terminating the ConnHdlr. Change-Id: Ia0342a9bb346929e0e538f4cb571abfc4acac6bf --- msc/MSC_Tests.ttcn | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'msc/MSC_Tests.ttcn') diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 63e90f49..bdd9f62f 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -702,12 +702,15 @@ friend function f_lu_and_mo_call_sccp_tiar_timeout(charstring id, BSC_ConnHdlrPa T_wait_iar.stop setverdict(pass); } - [] MGCP.receive(tr_DLCX(?)) { repeat; } [] T_wait_iar.timeout { setverdict(fail, "Timeout waiting for T(iar) triggered SCCP RSLD"); mtc.stop; } } + /* DLCX for both directions; if we don't do this, we might receive either of the two during + * shutdown causing race conditions */ + MGCP.receive(tr_DLCX(?)); + MGCP.receive(tr_DLCX(?)); setverdict(pass); } -- cgit v1.2.3