From 10f2bfa44496cc10233adaf033284481e304a1b3 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Tue, 9 Jul 2019 19:33:29 +0200 Subject: comments: BSC_Tests: clarify f_tc_ho_out_fail functions Change-Id: Ia0584324476d36077e92d1564d9d7e79a069addf --- bsc/BSC_Tests.ttcn | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'bsc') diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 88df9bc3..454ded7e 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3119,8 +3119,12 @@ testcase TC_ho_out_fail_rr_ho_failure() runs on test_CT { vc_conn.done; } -/* BSC asks for inter-BSC HO, receives BSSMAP Handover Command, but MS reports - * RR Handover Failure. */ +/* BSC asks for inter-BSC-out HO, receives BSSMAP Handover Command, but then no reply is received about HO outcome + * (neither BSSMAP Clear Command for success nor RR Handover Failure). 48.008 3.1.5.3.3 "Abnormal Conditions" applies + * and the lchan is released. + * Note: this test is a misnomer. On missing HO Detect, normally the old BSS receives an RR Handover Failure from the + * MS. Instead, this test is about the scenario in "Abnormal Conditions" as explained above. Leaving the test's name + * unchanged to not confuse jenkins result reports. */ private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHdlr { g_pars := f_gen_test_hdlr_pars(); @@ -3164,9 +3168,9 @@ private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHd } } - /* The MS never shows up on the remote BSS. Eventually the BSC times - * out (T8) and we run into 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": - * RR should be released and Clear Request should go to the MSC. */ + /* We get neither success nor failure report from the remote BSS. Eventually T8 times out and we run into 3GPP + * TS 48.008 3.1.5.3.3 "Abnormal Conditions": Clear Request should go to the MSC, and RR should be released + * after Clear Command */ var MgcpCommand mgcp; var PDU_BSSAP rx_clear_request; -- cgit v1.2.3