From da4a6958340307794394cb4a073191c0072879e0 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Thu, 14 Jun 2018 04:02:49 +0200 Subject: log / comment tweaks BSC_Tests: sprinkle logs to illustrate what the dyn PDCH tests expect. BSC_Tests: tweak comment to mention that inter-BSC HO MT *does* allow N-CONNECT from MSC. f_tc_assignment_fr_a5_1_codec_missing: mark the missing IE beyond doubt. Change-Id: I93c2914e766e200d89308cc81dd803e939b9b28c --- bsc/BSC_Tests.ttcn | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'bsc/BSC_Tests.ttcn') diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e94b781e..b44de9f4 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -518,7 +518,8 @@ testcase TC_chan_exhaustion() runs on test_CT { * Assignment Testing ***********************************************************************/ -/* Verify that the BSC refuses any BSSAP connection from the MSC (They are all BSC->MSC direction) */ +/* Verify that the BSC refuses any BSSAP connection from the MSC (They are all BSC->MSC direction, + * except for the inter-BSC handover, MT side) */ testcase TC_outbound_connect() runs on test_CT { f_init(1); @@ -1630,6 +1631,8 @@ private function f_tc_assignment_fr_a5_1_codec_missing(charstring id) runs on MS const OCT8 kc := '0001020304050607'O; ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType); + /* Omit: ass_cmd.pdu.bssmap.assignmentRequest.codecList */ + f_establish_fully(ass_cmd, exp_fail); } testcase TC_assignment_fr_a5_1_codec_missing() runs on test_CT { @@ -2367,26 +2370,31 @@ testcase TC_dyn_pdch_ipa_act_deact() runs on test_CT { var RslChannelNr chan_nr := valueof(t_RslChanNr_Bm(6)); + log("TCH/F_PDCH pchan starts out in TCH/F mode:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE); /* The BSC will activate the dynamic PDCH by default, so confirm that */ rsl_unused := f_exp_ipa_rx(0, tr_RSL_IPA_PDCH_ACT(chan_nr)); f_ipa_tx(0, ts_RSL_IPA_PDCH_ACT_ACK(chan_nr, ts_RSL_IE_FrameNumber(2342))); f_sleep(1.0); + log("TCH/F_PDCH pchan, PDCH ACT was ACKed, so now in PDCH mode:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE); /* De-activate it via VTY */ f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn); f_sleep(1.0); + log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE); /* re-activate it via VTY */ f_dyn_ipa_pdch_act(0, 0, chan_nr.tn); f_sleep(1.0); + log("TCH/F_PDCH pchan, PDCH ACT via VTY, so now in PDCH mode:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE); /* and finally de-activate it again */ f_dyn_ipa_pdch_deact(0, 0, chan_nr.tn); f_sleep(1.0); + log("TCH/F_PDCH pchan, PDCH DEACT via VTY, so now back in TCH/F mode:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, TCHF_MODE); /* clean up config */ @@ -2485,12 +2493,14 @@ testcase TC_dyn_pdch_osmo_act_deact() runs on test_CT { var RslChannelNr chan_nr := valueof(t_RslChanNr_PDCH(6)); + log("TCH/F_TCH/H_PDCH pchan starts out in disabled mode:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, NONE_MODE); /* The BSC will activate the dynamic PDCH by default, so confirm that */ rsl_unused := f_exp_ipa_rx(0, tr_RSL_CHAN_ACT_PDCH(chan_nr, ?)); f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 2342)); f_sleep(1.0); + log("TCH/F_TCH/H_PDCH requested to PDCH ACT on startup, which was ACKed, so now in PDCH:"); f_ts_dyn_mode_assert(0, 0, chan_nr.tn, PDCH_MODE); /* clean up config */ -- cgit v1.2.3