AgeCommit message (Collapse)AuthorFilesLines
2 daysRevert "MGCP: fix pattern warning"HEADmasterNeels Hofmeyr1-5/+5
For me this change causes MGCP parsing errors: setverdict(fail): pass -> fail reason: "Could not extract parameters for code "C"" Apparently the \r is after all necessary to parse MGCP. Maybe the '\r' is implicit when an '\n' occurs, but the non-SDP part of MGCP has *only* '\r' line breaks. This reverts commit a9a52fff15227710e1a3a2e6222a388a3da11168. Change-Id: I81d105b951590310c67f14f0b5d0c2777e206c5e
3 daysMGCP: fix pattern warningMax1-5/+5
Remove implied \r to fix following warnings: "Duplicate character `\r' in the character set. Please note the \n includes the \r implicitly. Use \q{0,0,0,10} if you would like to match the LF only." Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb
4 daysRequire to receive RANAP_CommonId after RANAP_SecurityModeCompleteAlexander Couzens1-0/+2
The SGSN will send a CommonId after it has sent SecurityModeComplete to support paging coordination in the RNC. Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
5 dayssgsn: replace variable bssgp with ran_indexAlexander Couzens2-15/+15
Since bssgp also been used for Iu connection, rename the variable to ran_index. Be consistent and use the same variable name everywhere. Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8
5 dayssgsn: replace variable gb_idx with ran_indexAlexander Couzens2-55/+55
Since gb_idx also been used for Iu connection, rename the variable to ran_index. Be consistent and use the same variable name everywhere. Change-Id: Ia119feee6a442c76dc337e75c07f4a385cd5e1df
5 dayssgsn: replace variable gb_index with ran_indexAlexander Couzens1-7/+7
Since gb_index also been used for Iu connection, rename the variable to ran_index. Be consistent and use the same variable name everywhere. Change-Id: I06b0c6184daeb886e8bd28d50bf18909d9244dc6
5 dayssgsn: replace variable bssgp_index with ran_indexAlexander Couzens1-10/+10
Since bssgp_index also been used for Iu connection, rename the variable to ran_index. Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307
5 dayssgsn: TC_attach_check_complete_resend: Expect LU sent to HLRPau Espin Pedrol1-0/+2
SGSN is expected to submit an LU after initial GMM Auth Change-Id: Ie2e8f5b9740c7429f5f0bf28e35707a61f23b565
6 dayslibrary/L1CTL_PortType.ttcn: use templates from GSM_RR_TypesVadim Yanitskiy2-19/+9
Get rid of template t_IMM_ASS, which is a part of L1CTL_Types.ttcn. Prepare generic (for both CS and PS) template on top of tr_IMM_ASS, and use it in f_L1CTL_WAIT_IMM_ASS(). Change-Id: I3a410ec3c41e3eefd23071bfb0d80feda82177a5
6 dayslibrary/PCUIF_Types.ttcn: mark PCUIF_Text as 'null_terminated'Vadim Yanitskiy1-1/+1
This is a TITAN specific attribute that allows to indicate that a field of type 'charstring' is '\0'-terminated. Without that attribute, 'PCUIF_Text' is mixed with the padding characters: "" & char(0, 0, 0, 0) & char(0, 0, 0, 0) & ... Change-Id: Ic81fff4c82871bb29a2385b9ee7a2dd98f67dfb0
8 daysInitial TTCN-3 test suite for osmo-remsimHarald Welte15-1/+2252
This adds shared infrastructure and initial test suites for osmo-remsim-{server,client,bankd}. Change-Id: I00034d3a991f0f881cfd8ff0bfc4557113daf830
8 dayssgsn: add TC_geran_attach_iu_rauAlexander Couzens1-1/+26
MS <-> SGSN: Successful Attach over Geran MS <-> SGSN: Routing Area Update over Iu The test case will crash the SGSN and is not included in the default run. Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
10 daysRevert "library/PCUIF_Types.ttcn: inform RAW codec about PADDING in PCUIF_data"Vadim Yanitskiy1-7/+2
This reverts commit dd6d5d1baa62dc9d50fa90ef01fccb8a10284d53. The PADDING seems to be a very experimental feature of TITAN. It works very well for decoding of messages, so the padding bytes are getting recognized as expected, but encoding is broken. Not only the data buffer and its length are encoded in a wrong way, but other fields too. Change-Id: Ieefa61232eb215a19a02e490255332e28e23b8f8
10 dayssgsn: add TC_iu_attach_geran_rauAlexander Couzens1-0/+23
MS <-> SGSN: Attach over Iu MS <-> SGSN: Routing Area Update over Geran The tess case will crash the SGSN and is not included in the default run. Change-Id: Ie043639638a640a2041324fc910964385a41c77d
10 dayssgsn: extend f_routing_area_update() to support IuAlexander Couzens1-5/+27
Allow Iu tests to use f_routing_area_update() Change-Id: Ic03952a04c00a4fc437ef39c5ee046549c122c8b
10 dayssgsn: make the ranap interface optionalAlexander Couzens2-11/+24
Allows to use the test cases without STP Change-Id: I43df456c2d5aa3ba3ea9e34da3f0f96b55f7c9a1
10 dayssgsn: add Iu Attach RequestHarald Welte2-0/+47
MS -> SGSN: Attach Request IMSI MS <- SGSN: Identity Request IMEI MS -> SGSN: Identity Response IMEI MS <- SGSN: Auth Request MS -> SGSN: Auth Response MS <- SGSN: Attach Accept MS -> SGSN: Attach Complete Change-Id: I66069e31c30d33934ad57cc2b8794f56ffd5c7d6
10 daysL3 Templates: PDU_L3_MS_SGSN: export ptmsi in template signatureAlexander Couzens1-2/+3
Iu packets needs to contain an ptmsi as tlv in difference to Gb. Change-Id: I7ba51a28524261dd1c7f4f2586ee6ebc970ea944
10 dayssgsn: introduce f_send_l3() to allow one function for Gb & IuAlexander Couzens1-48/+132
f_send_l3() replaces f_send_l3_gmm_llc() to have one function which sends L3 messages for Iu and Gb at the same time. This allows to share most of the tests between Iu & Gb. Change-Id: If47ad2be459ca7b87d9071d9ff020a51821e4433
12 dayslibrary/LAPDm_RAW_PT.ttcn: use templates from GSM_RR_TypesVadim Yanitskiy1-16/+24
Get rid of t_IMM_ASS_TBF_UL_DYN, use tr_IMM_TBF_ASS instead. Also, use both tr_PacketUlDynAssign and tr_PacketUlSglAssign for matching UL TBF assignment. Change-Id: Icb7dab04a1e2a833c14754d872bd4b85af3d58a5
12 dayslibrary/GSM_RR_Types.ttcn: introduce generic tr_IMM_TBF_ASSVadim Yanitskiy3-35/+33
Both 't_IMM_ASS_TBF_DL' and 't_RR_IMM_ASS_TBF_DL' templates were introduced for a specific task - matching Packet Immediate Assignment (Downlink TBF) by TLLI. In the upcoming changes we will also need to match Uplink TBF assignment, and more generic fields such as Timing Advance. Let's add a generic template for Packet Immediate Assignment and allow passing IaRestOctets as a parameter. Change-Id: I492cf990820ba153ea71469b8b623e56e031e549
12 dayslibrary/GSM_RR_Types.ttcn: refactor IaRestOctHH codingVadim Yanitskiy3-63/+119
According to 3GPP TS 44.018, section, IA Rest Octets IE starting with 'HH' bits may contain one of the following CSN.1 encoded components: 7 6 5 4 3 2 1 0 Bit Numbers H H 0 0 . . . . Packet Uplink Assignment H H 0 1 . . . . Packet Downlink Assignment H H 1 . . . . . Second Part Packet Assignment We already have (partial) support for the first two, while the last type has not been supported so far. Let's add it. Also, this change introduces several templates for IA Rest Octets IE and some of its components mentioned above. This would allow us to abstract the API users from dealing with further changes, e.g. adding a coding attribute 'CSN.1 L/H' and missing fields. Change-Id: Ib3a21e7c5fa1cad4466e3a09fa70540de7f6ecc5
12 dayslibrary/GSM_RR_Types.ttcn: fix: apply '2B'O padding to GsmRrMessageVadim Yanitskiy1-3/+5
For some reason TITAN starts padding not from the beginning of record ImmediateAssignment, but from it's wrapper GsmRrMessage. As a result, dec_GsmRrMessage() warns about undecoded octets: Data remained at the end of the stream after successful decoding '2B2B2B'O Similarly enc_GsmRrMessage() generates a shorter payload. Let's work this around by applying PADDING attribute to GsmRrMessage. Change-Id: I5fe327383402956213c20a68b18b8a48381156b5
12 dayslibrary/GSM_RR_Types.ttcn: fix hard-coded L2 pseudo length in tr_IMM_ASSVadim Yanitskiy1-1/+1
Change-Id: I1d3b0fbd01875cdb94b923a1521b1387a33adcd8
12 dayslibrary/GSM_RR_Types.ttcn: fix ImmediateAssignment coding regressionsVadim Yanitskiy1-4/+6
Since I403d2141536303a966be7ff51b06c3de202412e6, IA Rest Octets is a mandatory IE. When changing the definition of ts_IMM_ASS, I forgot to mark its optional 'lh', 'hl', and 'hh' as omitted explicitly. As a result, many of our TTCN-3 test cases were broken: Dynamic test case error: Using an unbound optional field. Also, in Ifdcdcf50709fcc03195cb8ef6092977e26f910ec I added an optional field 'pad' to record 'IaRestOctets'. That was not the best solution, because padding should be handled transparently. Let's get rid of that dummy field and equip both 'ImmediateAssignment' and 'IaRestOctets' records with proper padding attributes. The later one needs to be marked with 'CSN.1 L/H' attribute in the future, but for now we should keep it octet-aligned. Change-Id: I69d5fbd8e3388e287bfa54f02454d207e62ee640
14 daysbsc: Test that ETWS Primary Notification is passed via RSL to PCHHarald Welte1-0/+77
The BSC must not only pass the ETWS Primary Notification from CBSP down every dedicated channel, but it must also send it via an Osmocom-specific RSL message to enable the BTS to brodcast it via the PCH (P1 Rest Octets) and pass it to the PCU for PACCH. Change-Id: Ia418095844aaa418a4e2ff6fd75d8a4b3c8bb9c0 Related: #4046
14 daysbsc: Test that ETWS Primary Notification are sent via dedicated channelsHarald Welte3-1/+108
When the BSC receives an ETWS PN via CBSP, it must send it through all established dedicated channels of the matching BTSs. Related: OS#4046 Change-Id: Ib057bd251604e9bae968e71de245b3bbf737a356
2019-09-06CBSP: Fix receive templates if channel_ind == omitHarald Welte1-3/+9
Change-Id: I6e15a7499b5da6f63a517f303576a877ea038788
2019-09-06bts: Test if BTS forwards ETWS Primary Notification to PCUHarald Welte2-2/+72
All MS/UE must be notified of ETWS Primary Notifiations. Depending on their state, the notification goes different paths: * CS dedicated mode: BSC sends it as L3 message over LAPDm / DCCH * CS/PS idle mode: BTS sends paging messages on PCH * PS TBF active: PCU send Packet Application Info This tests the last of the three methods by checking that a ETWS Primary Notification sent on RSL to the BTS is received by the PCU socket. Change-Id: I2661df7f7d870a0ac1c89bb8a85df81644b00b0a Related: OS#4047, OS#4048 Depends: osmo-bts Ic0b3f38b400a0ca7e4089061ceb6548b0695faa6
2019-09-06Revert "bts: f_init_pcu: sleep before connect"Oliver Smith1-4/+3
This reverts commit c089b415f5e3bbf5eb2de435b925581ca42d8872. The additional sleep caused other tests to break, probably because it triggered race conditions: * TC_pcu_socket_connect_multi * TC_pcu_socket_connect_si3gprs * TC_si_sched_13_2bis_2ter_2quater Adjust TC_pcu_socket_verify_info_ind test case error message to mention OS#4179. This test is flapping now, most of the time the BTS sends a CellID 0 because it did not receive the real CellID from the BSC yet. Related: OS#4179 Change-Id: I2115c337f4601a4614b140715323c42803b003ee
2019-09-05library/GSM_RR_Types.ttcn: fix: IA Rest Octets may have optional paddingVadim Yanitskiy1-1/+2
According to 3GPP TS 04.08 (version 7.21.0), section and table 10.5.45, IA Rest Octets IE may contain spare bits. Let's add an optional field 'pad' to record 'IaRestOctets'. NOTE: somehow this change crashes my TITAN runtime: dec_GsmRrMessage(): Stream before decoding: '2D063F100FE3673A096B0000C800300B2B2B2B2B2B2B2B'O *** Error in `././PCU_Tests': malloc(): memory corruption: 0x000000000074a790 *** while the recent version works just fine. Change-Id: Ifdcdcf50709fcc03195cb8ef6092977e26f910ec
2019-09-05library/GSM_RR_Types.ttcn: fix: IA Rest Octets is mandatory IEVadim Yanitskiy1-3/+10
According to 3GPP TS 04.08 (version 7.21.0), table 9.18, IA Rest Octets (see is a mandatory IE, not optional. Change-Id: I403d2141536303a966be7ff51b06c3de202412e6
2019-09-05library/PCUIF_Types.ttcn: inform RAW codec about PADDING in PCUIF_dataVadim Yanitskiy1-2/+7
PADDING is one of the TITAN specific language extensions [1], which tells the RAW codec that an encoded payload shall end at a boundary fixed by a multiple of 'padding' unit bits counted from the beginning of the message. Let's use it for record 'PCUIF_data', where the fixed-size buffer is located in between the other fields, so padding will be ignored by the RAW coding after decoding: $HOST: dec_PCUIF_Message(): Decoded @PCUIF_Types.PCUIF_Message: { msg_type := PCU_IF_MSG_DATA_REQ (0), bts_nr := 0, spare := '0000'O, u := { data_req := { sapi := PCU_IF_SAPI_AGCH (2), len := 23, data := '2D063F100FE3673A096B0000C800300B2B2B2B2B2B2B2B', ... } } } As a result, we don't have to deal with padding manually and can safely use 'decmatch' statement in the receive templates. [1] usrguide/referenceguide/4-ttcn3_language_extensions.adoc Change-Id: I5808954b5c67c3239e795e43ae77035152d359ef
2019-09-05bsc: Test suite for CBSP (Cell Broadcast Service Protocol)Harald Welte7-6/+552
In this testsuite, we simulate BTS and CBC by attaching to RSL and CBSP protocol interfaces of the BSC. We then issue a variety of CBSP commands to the BSC and check for corresponding action on both the BTS- facing RSL as well as responses on the CBSP side. Change-Id: Ia6ffac181f50586d06d2f29bca1c57285179e861
2019-09-05CBSP: Hack to make receive templates workHarald Welte1-5/+5
For some reason, the 'ifpresent' annotation doesn't work in lists of templates. This means we have to re-think the CBSP template structure at some point. However, this would be a significant detour and I'd rather have working tests right now, so we can verify the actual functionality merged into the BSC right now. Change-Id: I3fa174b4352c17feaea4d33f773877104d4913c4
2019-09-05bts: Add test for ETWS Primary Notification via P1 Rest OctetsHarald Welte2-1/+198
Change-Id: I247ea0f336e4ae9eecb1e8166f2326bdd2c299f4 Related: OS#4047
2019-09-04Add CBSP_CodecPort + CBSP_AdapterHarald Welte4-0/+259
Change-Id: I36b39b320c21502395f9d51d769d76adf5f5d602
2019-09-04Add CBSP (Cell Broadcast Service Protocol) types + templatesHarald Welte2-0/+1125
Change-Id: Ida2e0af7d282fd7d5318110c05efa5a10114242c
2019-09-03ggsn: Delete previously activated pdp ctx in *_interact()pespin/ggsnPau Espin Pedrol1-0/+3
This change fixes some GGSN_Tests failing lately since osmo-ggsn correctly sends DeleteCtxReq for dangling pdp ctx upon increased Recovery counter received, and tests are not expecting that (because they don't expectect dangling pdp ctx from previous tests). Change-Id: I232298e2bfd8bfc99d82cbf5803d11db7eb1786a
2019-09-02sgsn: Proper shutdown of RAN_Adapter componentsPau Espin Pedrol2-0/+88
Otherwise TTCN3 errors sproadically during shutdown: """" SCCP_Emulation.ttcn:5661 Receive operation on port SCCP_SP_PORT succeeded, message from SGSN_Test_0-RAN(414) ... SCCP_Emulation.ttcn:5293 Sent on MTP3_SCCP_PORT to SGSN_Test_0-M3UA(415) @SCCP_Types.ASP_MTP3_TRANSFERreq_sccp SCCP_Emulation.ttcn:5293 Outgoing message was mapped to @MTP3asp_Types.ASP_MTP3_TRANSFERreq SCCP_Emulation.ttcn:5293 Dynamic test case error: Sending data on the connection of port MTP3_SCCP_PORT to 415:MTP3_SP_PORT failed. (Broken pipe) SCCP_Emulation.ttcn:5293 setverdict(error): none -> error """ Similar shutdown is already done in f_cleanup() of SCCP_Tests.ttcn. Related: OS#4176 Change-Id: I471eb851e5d41de5d8d974ec81be27024d7d313a
2019-09-02BSSGP_Emulation: add BssgpDecodeDepthOliver Smith3-18/+37
Make the decoding level (BSSGP, LLC, SNDCP, L3) configurable, so the existing PCU tests, that expect messages only decoded to the BSSGP level, can pass again. Move the SNDCP decoding in f_dec_bssgp above the L3 decoding, so f_dec_bssgp goes through the layers in the reverse order of f_send_bssgp_dec. I have verified, that all testsuites using the BSSGP Emulation (SGSN, PCU, PCU-SNS) are still working with this patch. Related: OS#4180 Fixes: 955aa94504510139a12d223071cf49ef90788a3d ("BSSGP_Emulation: Abandon "BssgpDecoded" intermediate structure") Change-Id: I8f76385528c1de98c557cee451c0e0dfd182b605
2019-08-30sgsn: update configs for running without dockerOliver Smith3-6/+71
Base on docker-playground.git's ttcn3-sgsn-test/*.cfg files, change IPs to 127.0.0.* (keep last octet), log to stderr. The reasoning behind the IP change is, that using almost the same IP as in the docker configs makes it easier to compare the configs. Change-Id: I15b5a943e9c665dfd4eb6b30bff84afc8adeb4a2
2019-08-30pcu: add configs for running without dockerOliver Smith5-0/+346
Base on docker-playground.git's ttcn3-pcu-test/*.cfg files, change IPs to, log to stderr, adjust pcu-socket path. Change-Id: Iff3e5e6cf0c608680c8c5f9f83e8bc1032274ea9
2019-08-30pcu/GPRS_TBF.ttcn: less verbose loggingOliver Smith1-3/+0
Reduce the formatted log size of TC_ul_tbf from ~140 MB to ~8 MB. Related: OS#3925 Change-Id: Ibccfc399a6e8b50e4f01b5f167c47fbbde4533ed
2019-08-30BSSGP_Emulation: as_unblocked: fix SIG broadcastOliver Smith1-1/+1
I am not aware that this caused breakage anywhere. But from reading the patch, this is a regression that needs to be fixed. Fixes: 955aa94504510139a12d223071cf49ef90788a3d ("BSSGP_Emulation: Abandon "BssgpDecoded" intermediate structure") Change-Id: I36a9a4d61be52a4d86ac1cbf6e6976cf01cff7c6
2019-08-29bts: add configs for running without dockerOliver Smith3-4/+225
Base on docker-playground.git's ttcn3-bts-test/*.cfg files, change IPs from 172.18.9.* to 127.0.0.* (last octet unchanged). Change-Id: I9eb2bb4599a4e874424f73483d9658a4467b8b8c
2019-08-29bts: add test TC_pcu_socket_verify_info_indOliver Smith1-0/+23
Verify that the CellID of SI3 (TS 04.08 9.1.35) and other values are passed properly to the PCU socket. A bug in OsmoBTS is currently causing it to send a byte-swapped CellID, related fix is in [1]. [1] I68faf4558f0686fb2a3db24077dceaae05bf0262 (osmo-bts) Related: OS#3854 Change-Id: I6516808f4b9e9a2301f9ccc1e55ded14e7334c33
2019-08-29bts: f_init_pcu: sleep before connectOliver Smith1-0/+3
Give the emulated BSC side some time to send the various SI via RSL. This workaround makes OsmoBTS send the correct CellID and other information instead of empty values to the PCU socket. The next commit tests these values. Related: OS#4179 Change-Id: I547f2b8e0796b6976506c28b1b493b1f5bce28f8
2019-08-28sgsn: Introduce test TC_attach_echo_timeoutPau Espin Pedrol2-1/+63
This test verifies sgsn drops all GGSN related pdp context when that GGSN stops answering echo requests. Change-Id: Ic31748924e7bf05ea2ccf2b1be0c460eefed5782
2019-08-23ggsn: Introduce test TC_pdp_act2_recoveryPau Espin Pedrol2-42/+111
Some code is moved out of f_pdp_ctx_act() into f_handle_create_req() in order to re-use it in the test. Related: OS#4165 Change-Id: I48c1bc9287ce8b820e5ea672dffbc5a8503f16d7