AgeCommit message (Collapse)AuthorFilesLines
11 daysFix suspend/resume testsDaniel Willmann1-0/+12
Ensure that a suspend/resume was sent before sending the *_(N)ACK. In reality these can only happen together and our TLLI cache removes the entries after it sees the corresponding (N)ACK so it will not forward the second message. Change-Id: Ie0fd81edb748d3c638e42c4418ca514095c55861 Related: SYS#4865, OS#4472
2021-01-07CTRL: Introduce support to run osmocom CTRL serverPau Espin Pedrol9-22/+60
Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255
2021-01-07CTRL: Fix tr_CtrlMsgGet containing invalid value in val fieldPau Espin Pedrol1-1/+1
"val" field is not used in GET commands and is hence set to omit by TTCN3 decoder. Change-Id: If1a273a2be71040eaea2189a0aeaf737adf848e5
2021-01-05SGSN_Tests: test RIM message passingPhilipp Maier1-0/+90
Add a testcase to test if RIM messages can be passed on the SGSN back and forth. Related: SYS#5103 Change-Id: If0ab08dcdc28819740cc07fd4dc1fea47ba10843 Related: SYS#5103
2021-01-05Osmocom_Gb_types: add RIM templatesPhilipp Maier1-0/+806
The template set we use for testing the GB (BSSGB) interface on osmo-sgsn and osmo-pcu lacks templates to generate RIM (ran information management) messages. The records and unions are already specified in BSSGP_Types.ttcn, we just need to form templates in order to be able to use them. Change-Id: Ic495e0bb6ceb2b65cbc7c3da7ee519a013aede55 Related: SYS#5103
2021-01-05deps/BSSGP: Use specific commit hashHarald Welte1-1/+1
Using "master" doesn't really work as the local master branch already exists even if we change the 'remote' to a different URL, see Change-Id: Id5f5ba52dbc9cd51dda2e91391c901b56756e2db
2021-01-04gbproxy: osmo-gbproxy.cfg: support new sgsn syntaxAlexander Couzens2-2/+2
osmo-gbproxy has a new syntax for sgsns to support pooling Change-Id: I157dbbe42db4ed03861b914e91e49764b0b1a1bb
2021-01-04gbproxy: change osmo-gbproxy.cfg to support ns2 vty2Alexander Couzens2-26/+36
All test case (except 3 which fails on jenkins as well) succeed. Change-Id: I1c3fde35cec7fa0adf2bef7659dfc19bf301ffa9
2021-01-04BSC_Tests: fix f_recv_next_si1(): skip unmatched RSL messagesVadim Yanitskiy1-0/+1
Since Idb453fc894584ccf4f5f8b45a24421db958e9478, osmo-bsc does send ip.access specific Measurement Pre-Processing Defaults. This message currently blocks the 'alt' statement in f_recv_next_si1(), so all test cases calling it fail due to the guard timeout. What's even worse, both TC_si_acc_rotate() and TC_si_acc_ramp_rotate() dynamically configure the IUT in order to re-generate and send System Information messages periodically. If any of them fails prematurely, the related configuration parameters would remain active, so the IUT would continue sending System Information messages, causing failures in subsequent test cases. Let's simply ignore all unmatched messages in the 'alt' statement. Change-Id: I1a85a046e1a8ebcd494354dddcbcc9707fdf5ee9
2021-01-03BSC_Tests: fix expectations in TC_assignment_codec_amr_h_start_mode_4Vadim Yanitskiy1-1/+3
Change-Id: I791602a0bb56e192c9263982b9f20ac0738281a2 Related: OS#4898
2021-01-03BSC_Tests: drop redundant f_init() in f_test_si2quater()Vadim Yanitskiy1-2/+0
There is a global boolean flag that would make f_init() return early if it's called twice. This is exactly the case here. Change-Id: Ic33786c4851d2682deec7c22fafb99043c1c1cf6
2021-01-03BSC_Tests: fix unreachable code after f_shutdown_helper()Vadim Yanitskiy1-4/+4
This function does 'mtc.stop', so it must be always called last. Change-Id: If2c991d6ac23e43aafd32814ca17cf2093cb1522
2021-01-03BSC_Tests: add missing f_shutdown_helper() statementsVadim Yanitskiy1-0/+17
Change-Id: I1a89e3776d7705d3d54b096ef420b2bbe574ab07
2021-01-03BSC_Tests: fix early mtc.stop in TC_chan_rel_rr_cause()Vadim Yanitskiy1-1/+2
Calling f_shutdown_helper() in f_tc_chan_rel_rr_cause() leads to premature test case termination, so only one out of 6 cause values gets checked. Move it to TC_chan_rel_rr_cause(). Change-Id: Ic7df15b496fc0750e4f694b1ae79398216f498a7
2020-12-21NS_Emulation.ttcnpp: complete SGSN emulation with SNSAlexander Couzens1-8/+6
The emulation of an SGSN with SNS was incomplete. The SNS procedure was completed. However the NSVCs didn't moved into an unblocked state. Also sending a NS_ALIVE at the beginning is wrong. Change-Id: I54c2d9d5b34d791be354298171d04180a9b263c3
2020-12-18cosmetic: bsc: Fix tab<->space indentPau Espin Pedrol1-1/+1
Change-Id: I8b8670fb820d258a5a56f3fdb007f7e59bfd374f
2020-12-16PCU_Tests_SNS: improve SGSN originated BVC-RESETsAlexander Couzens2-6/+32
The BVC-RESETs are a little bit more complicated. The PCU will send a BVC-RESET after the NSE become available. Ensure the RESET is received and ignored so there is no race condition if both sides send a BVC-RESET at the same time. The test case TC_sns_1c1u_so_bvc_reset is still failing because the PCU can't handle BVC-RESETs properly (both PTP and signalling). Change-Id: Id681749d75073c1d50a4b0a2e86f0a2dd0955b45
2020-12-16deps/Makefile: temporarily use own repo for ProtocolModules.BSSGPPhilipp Maier1-3/+3
Temporarily use titan.ProtocolModules.BSSGP_v13.0.0 from as we have some fixes that are not yet part of upstream. Change-Id: I5d7261a5ac33a0231c1a3d73bdff7fb099568687
2020-12-13BTS_Tests: as_l1_sacch(): fix Measurement Report paddingVadim Yanitskiy1-2/+2
According to 3GPP TS 44.018, section, we should pad with zeroes. Change-Id: I912027fd53b12ff118254e941d6e5e696e1dd410
2020-12-12gbproxy: Remove redundant part from config fileHarald Welte1-5/+0
If a given setting is identical to the GBProxy_Tests.ttcn compile-time default, we don't need to repeat it in the config file. Change-Id: I3359f632eaf53bc602b1d10bb51de357f0eb2b45
2020-12-12gbproxy: Be mover verbose about BVC-UNBLOCK failure at start-upHarald Welte1-2/+3
Change-Id: Ic849e1f932de21a443cd0274e02e0f2ccd423515 Always capture lo interfaceHarald Welte1-1/+1
The loopback interface should always be captured, as it includes the 'ping' commands we use to detect the start of the packet capture. Change-Id: Ic3aee59dd230141a5d182e9babf8d33d59144aa4
2020-12-11pcu: Fix counter expectancies after LLC UI dummy frame fixes in PCUPau Espin Pedrol1-2/+2
Recent commit 7d0f9a0ec383fcfca934731bd6979b6be6629c90 in osmo-pcu.git fixed situation where lots of unneeded LLC UI dummy frames where being sent. As a result, osmo-pcu correctly counts less dl rlcmac payload bytes being sent, so we must adjust our test expectancies. Related: OS#4849 Change-Id: I01c34a0948094b17cc0d67e613cd9b756f78c372 Accept running as root or setuid dumpcapHarald Welte1-1/+8
Change-Id: Id97fb22e0018739a07e46ecaf26463248554f276
2020-12-11ttcn3-tcpdump-start: Fix path of setcapHarald Welte1-1/+1
if we test if /sbin/setcap exists, we als should execute it from that path, as running from a normal user doesn't have /sbin included in $PATH Change-Id: I5131f869f86e6d136e0485da5e3749abbfc951e3
2020-12-11gbproxy: Properly capture HDLC/FR traffic in addition to ethernetHarald Welte3-0/+152
We cannot use "-i all" but must list each interface separately, which is only supported by dumpcap. We also must write pcapng files. Change-Id: Id412af3bb6bcad5e0f2cf40a6dc497d7e4f3d948
2020-12-11gbproxy: Fix log messages in timeout situationsHarald Welte1-2/+2
Printing an unbound 'rx' variable when nothing was received due to timeout is somehow not really useful. Print what we expected to receive. Change-Id: I4fee89baa954736ae8298b63667297dd57d8ec4f
2020-12-10sgsn+pcu: Port suspend/resume cases to new BSSGP_CT:GLOBAL portHarald Welte4-7/+12
For 12+ days, suspend/resume related SGSN + PCU TTCN3 tets have been failing. It was the introduction of the BSSGP_CT:GLOBAL test port in I40d973d80709f5d56f59247e8647b52754f09bc8 + I805372f3024a0ec2491a24422e02c0bc6dc669d2 which caused the related PDUs now to no longer show up where they used to. Change-Id: I1977302fef4868dc1c330bc6f48f6a6608949393 Closes: OS#4902
2020-12-10gbproxy: Add test for FLOW-CONTROL-MS procedure (TC_fc_ms)Harald Welte2-0/+134
Change-Id: Ie087ee8e8adfb963d21f35c60628214d4297250d Closes: SYS#5210
2020-12-10deps: Update AF_PACKET dependency to version with socket/bind race fixHarald Welte1-1/+1
Change-Id: Icd773273d3ff8ff6d36ce472b8bd2e8a9b1e2e19
2020-12-10pcu: SNS: fix typoAlexander Couzens1-1/+1
Change-Id: Iedb6b3f38d87ea3ac29c4bcaaf50e771b0b8a750
2020-12-10pcu: SNS: add TC_sns_add_existentAlexander Couzens1-3/+12
Try to add via SNS an already existent NSVC which should fail. Change-Id: I096bcbe38d82d08a150a2f8e56f6bc02353273a1
2020-12-10pcu: SNS: remove TODO expect FLOW-CONTROL BVCAlexander Couzens1-1/+0
It should not be expected in a new NSVC. Change-Id: I142c87d496f08d603ab8e1e13c5a29ebe6596bb0
2020-12-10pcu: TC_sns_add: fix wrong udp port in SNS ADD messageAlexander Couzens1-1/+1
When sending the SNS ADD in the test case the ip/port to add must be different from the current NSVCs. Fixes: 90f1974fb040 ("NS_Emulation: Support multiple NS-VC within one NSE (NS-VCG)") Change-Id: I9bbbf1431468a452df324a7559518496e3eb48e3
2020-12-09gbproxy: Test case for BVC flow control procedureHarald Welte1-0/+71
Related: OS#4891 Change-Id: I6daa5848bd59b42f152de783bfdc602d1f2da861
2020-12-09gbproxy: properly shutdown at the end of the testHarald Welte1-1/+20
Destroying at least most of the components in an orderly fashion avoids at least most of the race conditions during test shutdown. Change-Id: I2aa4ef8a70c1139893c9621f5a6b6007b221c13d
2020-12-09gbproxy: Introduce global guard timer in test_CTHarald Welte1-4/+11
We did have a guard time in each ConnHdlr, but not in the MTC (test_CT). However, we do have tests that don't use any ConnHdlr, and those were so far ran without a guard timeout. Fix that. Change-Id: Iee90fc26a151c692d3c6f3eb6ad80f528f8d939f
2020-12-09gbproxy: Rename PCU port to PCU_PTP; SGSN port to SGSN_PTPHarald Welte1-31/+31
This way it's more obvious that it refers to the PTP BVC, like we already use PCU_SIG and SGSN_SIG for the signaling BVCs. Change-Id: Ie8d327b0c6fae0e7963cc5907ab0bc94e97c67f3
2020-12-09gbproxy: cosmetic: More comments / section headersHarald Welte1-0/+24
Change-Id: I26162cd37908d60761182edd50c3aa8389486b7c
2020-12-09bssgp: Introduce "GLOBAL" port for PTP BVCHarald Welte1-8/+24
There are some messages/procedures on a PTP BVC which are not related to one specific TLLI, but affect the whole PTP BVC. First and foremost that is the FLOW-CONTROL-BVC. Let's check if the user is interested in handling those internally (by connecting to the GLOBAL port). If not, fall back to acknowledging all incoing FC-BVC and ignoring all ACKs. Related: OS#4891 Change-Id: Ib80a6a522dbcb33fd0e7bd31a73ef28fdc636f57
2020-12-09bssgp: rename tr_GLOBAL to tr_GLOBAL_SIGHarald Welte1-3/+3
... to indicate this is about the signaling BVC only. Change-Id: I646db452c89842465902b5167c9c86de51df1241
2020-12-09Osmocom_Gb_Types: Fix t_BVC_FC_BVC_ACK() TAG IE lengthHarald Welte1-1/+1
Change-Id: Ib9a09fea85110a4f0966c07d911e37234aa06391
2020-12-09gbproxy: Fix syntax error in Welte1-1/+1
Follow-up fix to I96e8b6a1a69148f770476e87c920dc256c1d7379 Related: OS#4520 Change-Id: I2eb6ffb3d0dba1405692c0e885622936d65cf95a
2020-12-08BTS_Tests_OML: add new test case TC_ipa_rsl_connect_nackVadim Yanitskiy1-0/+25
Currently osmo-bts seems to be sending IPA RSL Connect ACK unconditionally, even if the remote peer is not reachable. Change-Id: Ibfa58f670401907801f610578dd9b4ebf155a83a
2020-12-08bts/expected-results.xml: TC_sacch_chan_act_ho_sync should pass nowVadim Yanitskiy1-6/+1
Change-Id: I872111dae761bda038d2e881ab5f4e6b7f52ec90
2020-12-08bts/expected-results.xml: add missing SMSCB-over-SDCCH8 expectationsVadim Yanitskiy1-0/+10
Change-Id: I903ede1c78e103d24a93f2e6b0e1acd136405099
2020-12-08BSSGP_Emulation: Add RIM port to BSSGP_CTHarald Welte1-0/+20
This port is used for sending/receiving RIM related BSSGP messages. It exists once per BSSGP_CT Component (i.e. once per NSE), as RIM is global for the entire NSE. Change-Id: I04511df5dffbfe19faabf22014acc72b7673b7d6
2020-12-08gbproxy: Enable TC_load_sharing_dl based on modulepar; set that in FR testHarald Welte2-1/+3
Change-Id: I96e8b6a1a69148f770476e87c920dc256c1d7379 Related: OS#4520
2020-12-07NS_Emulation: Tolerate late NS-BLOCK-ACK / NS-UNBLOCK-ACKHarald Welte1-0/+6
Particularly in case both sides initiate a BLOCK or UNBLOCK procedure at almost the same time, it can happen thet we're already in BLOCKED state and receive a late BLOCK-ACK or in UNBLOCKED state and receive a late UNBLOCK-ACK. Let's just silently discard them instaed of generating NS-STATUS which may confuse the peer. Change-Id: I2e5b934e1cf6c6cf982d5ab1dbb32e8920b91071
2020-12-07gbproxy: Fix as_count_bvc_block()Harald Welte1-0/+1
we must continue to wait for more BVC-BLOCK after receiving the first one Change-Id: I4664899414869fe373d31bc72f6c1dcfbcc9071c