summaryrefslogtreecommitdiffstats
path: root/msc
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2019-02-28 08:43:00 +0100
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2019-03-14 03:43:52 +0000
commit82fd04b13b3dde28aa6d329343bdb9f4284bfaa4 (patch)
tree324fed3e43046ae84ff29c8916e90c45deccce7b /msc
parentb7aae8b957e70d6930efb7d988353b449ef21358 (diff)
msc: add codec to all Assignment Complete messages
So far we omit a Speech Codec (Chosen) from Assignment Complete messages, which is actually a mandatory parameter. osmo-msc seems to carry on nevertheless, but it actually shouldn't be able to. Always send a Speech Codec (Chosen). Change-Id: Ib35f019383db8ace05a9dc349648e2da7ba58bfa
Diffstat (limited to 'msc')
-rw-r--r--msc/BSC_ConnectionHandler.ttcn8
1 files changed, 6 insertions, 2 deletions
diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn
index 2cd666f..e6cf2b0 100644
--- a/msc/BSC_ConnectionHandler.ttcn
+++ b/msc/BSC_ConnectionHandler.ttcn
@@ -532,8 +532,10 @@ runs on BSC_ConnHdlr {
valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.mgw_rtp_ip_bss),cpars.mgw_rtp_port_bss));
BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, tla_ass)) {
var BSSMAP_IE_AoIP_TransportLayerAddress tla;
+ var BSSMAP_IE_SpeechCodec codec;
tla := valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.bss_rtp_ip), cpars.bss_rtp_port));
- BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla));
+ codec := valueof(ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}));
+ BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla, codec));
}
/* MS -> MSC: ALERTING */
@@ -633,8 +635,10 @@ runs on BSC_ConnHdlr {
/* expect AoIP IP/Port to match what we returned in CRCX_ACK above */
[] BSSAP.receive(tr_BSSMAP_AssignmentReq(omit, tla_ass)) {
var BSSMAP_IE_AoIP_TransportLayerAddress tla;
+ var BSSMAP_IE_SpeechCodec codec;
tla := valueof(ts_BSSMAP_IE_AoIP_TLA4(f_inet_addr(cpars.bss_rtp_ip), cpars.bss_rtp_port));
- BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla));
+ codec := valueof(ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}));
+ BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla, codec));
}
}