summaryrefslogtreecommitdiffstats
path: root/msc/MSC_Tests.ttcn
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2020-01-15 11:44:12 +0700
committerlaforge <laforge@osmocom.org>2020-01-15 16:08:31 +0000
commit2d3f846572bf29784b7831da994b586515fa8c4e (patch)
tree1eb850e7037deb247c8a3adca93445c26d592ec7 /msc/MSC_Tests.ttcn
parent33820765547e75d18decb621342f9e7c59c7002b (diff)
MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms
The MSC shall not send RP-ACK before the response from ESME. Change-Id: Ide1376cae8e75412039b7dc9f0b8bb390eab2280 Related: OS#4351
Diffstat (limited to 'msc/MSC_Tests.ttcn')
-rw-r--r--msc/MSC_Tests.ttcn8
1 files changed, 6 insertions, 2 deletions
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 94fac74..ccfc154 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2109,9 +2109,10 @@ friend function f_tc_smpp_mo_sms(charstring id, BSC_ConnHdlrPars pars) runs on B
/* Perform location update so IMSI is known + registered in MSC/VLR */
f_perform_lu();
- f_establish_fully(EST_TYPE_MO_SMS);
- f_mo_sms(spars);
+ /* MS/UE submits a MO SMS */
+ f_establish_fully(EST_TYPE_MO_SMS);
+ f_mo_sms_submit(spars);
var SMPP_PDU smpp;
var template SMPP_PDU tr_smpp := tr_SMPP(c_SMPP_command_id_deliver_sm, ESME_ROK);
@@ -2149,6 +2150,9 @@ friend function f_tc_smpp_mo_sms(charstring id, BSC_ConnHdlrPars pars) runs on B
[] SMPP.receive(tr_SMPP(c_SMPP_command_id_alert_notification, ESME_ROK)) { repeat; }
}
+ /* MSC terminates the SMS transaction with RP-ACK */
+ f_mo_sms_wait_rp_ack(spars);
+
f_expect_clear();
}
testcase TC_smpp_mo_sms() runs on MTC_CT {