summaryrefslogtreecommitdiffstats
path: root/ggsn_tests
diff options
context:
space:
mode:
authorStefan Sperling <ssperling@sysmocom.de>2018-07-19 19:24:38 +0200
committerStefan Sperling <ssperling@sysmocom.de>2018-07-19 19:58:06 +0200
commit8e7a396656f8d32c44254de0c65f26c6a2c833f2 (patch)
treeaff171920e8a9bd6da19ab314dcfbc85f7fbcb84 /ggsn_tests
parentd07ee1396f2ffdab316304083dc6a5c4ebad85dd (diff)
fix TC_pdp4_act_deact_with_separate_dns
Do not delete the PDP context too early, and look for the second DNS server in the correct place (2nd match on IPCP protocol, not 1st). Update a comment which talks about a bug which has been fixed. Change-Id: I109491cc9ccb060792e29bf6b2999ef48723edbf Related: OS#3319 Related: OS#3381
Diffstat (limited to 'ggsn_tests')
-rw-r--r--ggsn_tests/GGSN_Tests.ttcn5
1 files changed, 2 insertions, 3 deletions
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 6ae205f..3c99fd9 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -1017,11 +1017,10 @@ module GGSN_Tests {
if (not match(pco_neg_dns, pco_neg_dns_expected)) {
setverdict(fail, "Primary DNS IPv4 PCO option not found");
}
- f_pdp_ctx_del(ctx, '1'B);
/* Check if secondary DNS is contained */
- /* Note: this check fill fail due to a bug in osmo-ggsn, see also OS#3381 */
- pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 1);
+ /* This used to fail due to a bug in osmo-ggsn, see OS#3381 */
+ pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 2);
pco_neg_dns_expected := '0200000A8306'O & ggsn_ip4_dns2
if (not match(pco_neg_dns, pco_neg_dns_expected)) {
setverdict(fail, "Secondary DNS IPv4 PCO option not found");