summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2019-11-28 01:09:47 +0100
committerNeels Hofmeyr <neels@hofmeyr.de>2019-12-12 16:28:23 +0100
commitc3acceca1a782495ba0b012952c9c54bc8f7f16a (patch)
treec0f852a6819e460a66b8a323ce663b9b03b7734f
parentd8ad7c05434798854c5ae47b7834187cefb58168 (diff)
msc: expect only one Paging on GERANHEADmaster
After discussion on this thread: http://lists.osmocom.org/pipermail/openbsc/2019-November/013058.html Do not expect repeated Paging on GERAN. Pending clarification on 3G, still expect repeated Paging on Iu, though we are not 100% certain that this is indeed required. Fixes MSC_Tests.TC_lu_and_mt_sms_paging_repeated, but not MSC_Tests_Iu.TC_iu_lu_and_mt_sms_paging_repeated Change-Id: Ie914ea88f31ac158f4bd1700143bbe728dd05e0b
-rw-r--r--msc/MSC_Tests.ttcn30
1 files changed, 28 insertions, 2 deletions
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 6e482e2..a083606 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1974,11 +1974,37 @@ friend function f_tc_lu_and_mt_sms_paging_repeated(charstring id, BSC_ConnHdlrPa
f_vty_sms_send(hex2str(pars.imsi), "2342", "Hello SMS");
+ log("Expecting first Paging");
/* MSC->BSC: expect PAGING from MSC */
f_expect_paging();
- /* MSC->BSC: expect PAGING from MSC */
- f_expect_paging();
+ if (g_pars.ran_is_geran) {
+ log("GERAN: expect no further Paging");
+ } else {
+ log("UTRAN: expect more Paging");
+ }
+
+ timer T := 5.0;
+ T.start;
+ alt {
+ [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi)) {
+ setverdict(fail, "GERAN should not repeat Paging, but received a second Paging");
+ mtc.stop;
+ }
+ [not g_pars.ran_is_geran] BSSAP.receive(tr_RANAP_Paging(cs_domain, imsi_hex2oct(g_pars.imsi))) {
+ log("UTRAN: second Paging received, as expected");
+ setverdict(pass);
+ }
+ [] T.timeout {
+ if (g_pars.ran_is_geran) {
+ log("GERAN: No further Paging received, as expected");
+ setverdict(pass);
+ } else {
+ setverdict(fail, "UTRAN: Expected a second Paging");
+ mtc.stop;
+ }
+ }
+ }
/* Establish DTAP / BSSAP / SCCP connection */
f_establish_fully(EST_TYPE_PAG_RESP);