From 17cbe5cd2dd2c0a79835447b05bd379e121b3826 Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 16 Jan 2019 19:50:12 +0100 Subject: Log MDCX ACK for established lchan Previously LCHAN_RTP_EV_IPACC_MDCX_ACK was not permitted for LCHAN_RTP_ST_ESTABLISHED state in lchan FSM. However this message is normal in case of LCLS loop closed via IPA (as opposed to MGCP). Let's permit this message and log it to make debug output easier to read. Change-Id: Ib642df799f3405c4d707eb57b2ebc84386d7f03f Related: OS#2487 --- src/osmo-bsc/lchan_rtp_fsm.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index 84cc28729..2d15bf29b 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -565,13 +565,19 @@ static void lchan_rtp_fsm_established_onenter(struct osmo_fsm_inst *fi, uint32_t static void lchan_rtp_fsm_established(struct osmo_fsm_inst *fi, uint32_t event, void *data) { + struct gsm_lchan *lchan = lchan_rtp_fi_lchan(fi); + switch (event) { case LCHAN_RTP_EV_RELEASE: case LCHAN_RTP_EV_ROLLBACK: osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, 0); return; - + case LCHAN_RTP_EV_IPACC_MDCX_ACK: + LOG_LCHAN_RTP(lchan, LOGL_NOTICE, + "Received MDCX ACK on established lchan's RTP port: %s\n", + mgwep_ci_name(lchan->mgw_endpoint_ci_bts)); + return; default: OSMO_ASSERT(false); } @@ -689,6 +695,7 @@ static const struct osmo_fsm_state lchan_rtp_fsm_states[] = { .in_event_mask = 0 | S(LCHAN_RTP_EV_RELEASE) | S(LCHAN_RTP_EV_ROLLBACK) + | S(LCHAN_RTP_EV_IPACC_MDCX_ACK) , }, [LCHAN_RTP_ST_ROLLBACK] = { -- cgit v1.2.3