From 0fb9206c6a4032233a505267cc67d0e4f915a584 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Mon, 8 Jul 2019 14:41:22 +0200 Subject: make bsc_clear_request() static bsc_clear_request() is in fact used only within gsm_08_08.c, make it static to that file. Since the gscon FSM, "real" BSSMAP Clear are sent only by gscon_bssmap_clear(). bsc_clear_request() remains in use for legacy code paths in gsm_08_08.c: - the bsc_filter, i.e. for IMSI filtering; - in move_to_msc(), from handle_cc_setup(), a code path that is in fact not entirely clear to me. It seems to be an old functionality to serve multiple MSCs? Both of which I personally haven't seen in use, are not tested and should probably be completely removed. For now contain legacy code in the static context. Adjust comment. Change-Id: Ic89d0afad42e4b11183a13d2dc6b7bbf0b822fd9 --- src/osmo-bsc/gsm_08_08.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 2c6a6892a..6ca5455f6 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -509,6 +509,8 @@ early_fail: return false; } +static int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause); + /* * Plastic surgery... we want to give up the current connection */ @@ -635,8 +637,8 @@ done: return; } -/*! BSC->MSC: RR conn has been cleared. */ -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) +/*! BSSMAP Clear Request for legacy code paths, instead see gscon_bssmap_clear(). */ +static int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) { int rc; struct msgb *resp; -- cgit v1.2.3