aboutsummaryrefslogtreecommitdiffstats
path: root/src/osmo-bsc
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2020-10-29 01:56:44 +0100
committerNeels Hofmeyr <neels@hofmeyr.de>2020-10-29 23:47:32 +0100
commit3e5f08181cedd46e1f7ad82fd7cd63b1b18ef9af (patch)
tree3069f9d01727d31f0e486bb40378b98b29cee07f /src/osmo-bsc
parentfe608758973a7d59c2a8ce901c0d268f2cdde493 (diff)
add fixme comment for OS#3833
Diffstat (limited to 'src/osmo-bsc')
-rw-r--r--src/osmo-bsc/assignment_fsm.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index fde028ed9..7db37b2b6 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -492,6 +492,11 @@ void assignment_fsm_start(struct gsm_subscriber_connection *conn, struct gsm_bts
for (i = 0; i < req->n_ch_mode_rate; i++) {
conn->assignment.new_lchan = lchan_select_by_chan_mode(bts,
req->ch_mode_rate[i].chan_mode, req->ch_mode_rate[i].chan_rate);
+ /* FIXME: at this point there is merely an assignment request with a given ch_mode_rate. Writing this to
+ * conn->lchan->ch_mode_rate is a violation of scopes: the lchan->* state should only be modified
+ * *after* the assignment is confirmed to be completed. Before that, this data should live in
+ * conn->assignment or the lchan_activate_info, the designated places for not-yet-confirmed data. See
+ * OS#3833 */
conn->lchan->ch_mode_rate = req->ch_mode_rate[i];
if (conn->assignment.new_lchan)
break;