From d745a0e7f3814ae47515c474386ca5358c57b252 Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Wed, 7 Oct 2020 00:50:00 +0200 Subject: gprs_ns2_vty_create: remove bind pointer check The bind pointer can't be NULL because gprs_ns2_ip_bind() is either return 0 and bind is valid or != 0 and returning. Found-by: Coverity Fixes: CID#214854 Change-Id: I11d86c9cb36226701e51942f14d7a6412c3eff26 --- src/gb/gprs_ns2_vty.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'src/gb/gprs_ns2_vty.c') diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c index 01eb5341..c6c4b028 100644 --- a/src/gb/gprs_ns2_vty.c +++ b/src/gb/gprs_ns2_vty.c @@ -810,17 +810,15 @@ int gprs_ns2_vty_create() { } nse->persistent = true; - if (bind) { - nsvc = gprs_ns2_ip_connect(bind, - &sockaddr, - nse, - vtyvc->nsvci); - if (!nsvc) { - /* Could not create NSVC, connect failed */ - continue; - } - nsvc->persistent = true; + nsvc = gprs_ns2_ip_connect(bind, + &sockaddr, + nse, + vtyvc->nsvci); + if (!nsvc) { + /* Could not create NSVC, connect failed */ + continue; } + nsvc->persistent = true; } -- cgit v1.2.3