From c29d513a2b76bf689eb9a5d5914bd0f28065aa5d Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Mon, 21 Sep 2020 17:09:31 +0200 Subject: osmo_strlcpy: Avoid calling memcpy with size=0 Change-Id: Ic84af86d33c8a20f06036b13d0a10cf312582f0d --- src/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utils.c b/src/utils.c index 3c4a8c9f..168f85fe 100644 --- a/src/utils.c +++ b/src/utils.c @@ -545,7 +545,7 @@ uint64_t osmo_decode_big_endian(const uint8_t *data, size_t data_len) /*! Generic big-endian encoding of big endian number up to 64bit * \param[in] value unsigned integer value to be stored - * \param[in] data_len number of octets + * \param[in] data_len number of octets * \returns static buffer containing big-endian stored value * * This is like osmo_store64be_ext, except that this returns a static buffer of @@ -577,7 +577,7 @@ size_t osmo_strlcpy(char *dst, const char *src, size_t siz) if (siz) { size_t len = (ret >= siz) ? siz - 1 : ret; - if (src) + if (len) memcpy(dst, src, len); dst[len] = '\0'; } -- cgit v1.2.3