From 9e57a5a6974e92a2df73f9009f793c1a1f6206d9 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Mon, 21 Dec 2015 11:20:14 +0100 Subject: some comments / fixed typos --- include/osmocom/core/rate_ctr.h | 1 + include/osmocom/gsm/apn.h | 3 +++ include/osmocom/gsm/protocol/gsm_08_58.h | 2 +- include/osmocom/gsm/tlv.h | 2 +- src/gsm/lapd_core.c | 2 +- 5 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/osmocom/core/rate_ctr.h b/include/osmocom/core/rate_ctr.h index 4fecdfae..cdde353a 100644 --- a/include/osmocom/core/rate_ctr.h +++ b/include/osmocom/core/rate_ctr.h @@ -78,6 +78,7 @@ static inline void rate_ctr_group_upd_idx(struct rate_ctr_group *grp, unsigned i void rate_ctr_group_free(struct rate_ctr_group *grp); +/*! \brief Increment the counter by \a inc */ void rate_ctr_add(struct rate_ctr *ctr, int inc); /*! \brief Increment the counter by 1 */ diff --git a/include/osmocom/gsm/apn.h b/include/osmocom/gsm/apn.h index d8d73996..a256d973 100644 --- a/include/osmocom/gsm/apn.h +++ b/include/osmocom/gsm/apn.h @@ -9,5 +9,8 @@ #define APN_MAXLEN 100 char *osmo_apn_qualify(unsigned int mcc, unsigned int mnc, const char *ni); + +/* Compose a string of the form '.mnc001.mcc002.gprs\0', returned in a + * static buffer. */ char *osmo_apn_qualify_from_imsi(const char *imsi, const char *ni, int have_3dig_mnc); diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index 530bbc86..56cf4dd9 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -82,7 +82,7 @@ struct abis_rsl_cchan_hdr { /* \brief Check if given RSL message discriminator is transparent */ #define ABIS_RSL_MDISC_IS_TRANSP(x) (x & 0x01) -/* \brief RSL Message Tyoe (Chapter 9.1) */ +/* \brief RSL Message Type (Chapter 9.1) */ enum abis_rsl_msgtype { /* Radio Link Layer Management */ RSL_MT_DATA_REQ = 0x01, diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h index d54ef1af..c19034f0 100644 --- a/include/osmocom/gsm/tlv.h +++ b/include/osmocom/gsm/tlv.h @@ -402,7 +402,7 @@ int tlv_parse_one(uint8_t *o_tag, uint16_t *o_len, const uint8_t **o_val, const uint8_t *buf, int buf_len); int tlv_parse(struct tlv_parsed *dec, const struct tlv_definition *def, const uint8_t *buf, int buf_len, uint8_t lv_tag, uint8_t lv_tag2); -/* take a master (src) tlvdev and fill up all empty slots in 'dst' */ +/* take a master (src) tlv def and fill up all empty slots in 'dst' */ void tlv_def_patch(struct tlv_definition *dst, const struct tlv_definition *src); #define TLVP_PRESENT(x, y) ((x)->lv[y].val) diff --git a/src/gsm/lapd_core.c b/src/gsm/lapd_core.c index 8c5fe9c6..c59b0754 100644 --- a/src/gsm/lapd_core.c +++ b/src/gsm/lapd_core.c @@ -1940,7 +1940,7 @@ static int lapd_susp_req(struct osmo_dlsap_prim *dp, struct lapd_msg_ctx *lctx) return send_dl_simple(PRIM_DL_SUSP, PRIM_OP_CONFIRM, &dl->lctx); } -/* requesst resume or reconnect of link */ +/* request, resume or reconnect of link */ static int lapd_res_req(struct osmo_dlsap_prim *dp, struct lapd_msg_ctx *lctx) { struct lapd_datalink *dl = lctx->dl; -- cgit v1.2.3