From f4f4e8c310d63e746bec97e978c374bc58fd678a Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Tue, 22 Oct 2019 21:38:29 +0200 Subject: xua_rkm: Don't permit de-registration of rctx with ASP active Change-Id: Ie47eb205b397f3d2ce94c4ec3531664ed290a819 Closes: OS#4238 --- src/xua_rkm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/xua_rkm.c b/src/xua_rkm.c index 976d649..2d8a25e 100644 --- a/src/xua_rkm.c +++ b/src/xua_rkm.c @@ -30,6 +30,7 @@ #include "xua_internal.h" #include "xua_as_fsm.h" +#include "xua_asp_fsm.h" const struct value_string m3ua_rkm_reg_status_vals[] = { { M3UA_RKM_REG_SUCCESS, "SUCCESS" }, @@ -338,7 +339,11 @@ static int handle_rkey_dereg(struct osmo_ss7_asp *asp, uint32_t rctx, return -1; } - /* FIXME Reject if any ASP stillactively using this RCTX */ + /* Reject if ASP is still active */ + if (asp->fi->state == XUA_ASP_S_ACTIVE) { + msgb_append_dereg_res(resp, M3UA_RKM_DEREG_ERR_ASP_ACTIVE, 0); + return -1; + } rt = osmo_ss7_route_find_dpc(inst->rtable_system, as->cfg.routing_key.pc); if (!rt) { -- cgit v1.2.3