From 4c880a02f4186406a53ce7fa28b061ce3a0d3955 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Thu, 27 Apr 2017 11:48:15 +0200 Subject: osmo_sccp_user_sap_down(): Avoid uninitialized pointer deref When receiving an unknown primitive, we end up de-referencing an unassigned/uninitialized pointer for 'conn'. Let's properly catch that case and print an error message. Change-Id: Id1f5f293ea9bce8601d45164be670a7062d91802 Fixes: coverity CID#166947 --- src/sccp_scoc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 6d9916b..3a52ca6 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1628,6 +1628,11 @@ int osmo_sccp_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *op goto out; } break; + default: + LOGP(DLSCCP, LOGL_ERROR, "Received unknown primitive %s\n", + osmo_scu_prim_name(&prim->oph)); + rc = -1; + goto out; } /* Map from primitive to event */ -- cgit v1.2.3