From 02d0228a4000234bfb1aafb40d6adff5d9ce4c55 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Tue, 29 Oct 2019 14:13:10 +0100 Subject: xua_asp_fsm: Don't send M3UA ERR and then send ASPAC_ACK IF we cannot activate the ASP in response to an ASPAC, we should return just the error and not an error + ASPACK_ACK. Change-Id: I681021a13af9b91d8b2b849bd7149d6b1f783865 --- src/xua_asp_fsm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index 890a6b5..a6ee2ec 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -457,7 +457,7 @@ static void xua_asp_fsm_inactive(struct osmo_fsm_inst *fi, uint32_t event, void traf_mode != M3UA_TMOD_LOADSHARE && traf_mode != M3UA_TMOD_BCAST) { peer_send_error(fi, M3UA_ERR_UNSUPP_TRAF_MOD_TYP); - break; + return; } } if ((part = xua_msg_find_tag(xua_in, M3UA_IEI_ROUTE_CTX))) { @@ -465,7 +465,7 @@ static void xua_asp_fsm_inactive(struct osmo_fsm_inst *fi, uint32_t event, void rctx = osmo_load32be(&part->dat[i * sizeof(uint32_t)]); if (!osmo_ss7_as_find_by_rctx(asp->inst, rctx)) { peer_send_error(fi, M3UA_ERR_INVAL_ROUT_CTX); - break; + return; } } } -- cgit v1.2.3