diff options
authorPau Espin Pedrol <pespin@sysmocom.de>2017-06-21 10:46:28 +0200
committerHarald Welte <laforge@gnumonks.org>2017-06-22 06:23:04 +0000
commitb1510a11220766c77910f3ead3628e969a5ffc5f (patch)
parent34cb3c16a597e5793cfb59b1772967e0a5e89489 (diff)
sccp_scrc: Fix warning: uneeded constant evaulation
translate function is always present in the same file, thus we can remove this check. Fixes following warning: warning: the address of ‘translate’ will always evaluate as ‘true’ [-Waddress] if (translate && As requested by Harald, leave a comment there stating that there are some checks missing and yet to be implemented. The translate function check was used for this purpose. Change-Id: I48a711f3a43496e2c0c637f34f56784f765938c4
1 files changed, 1 insertions, 1 deletions
diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c
index 9a6a865..a4ce34c 100644
--- a/src/sccp_scrc.c
+++ b/src/sccp_scrc.c
@@ -348,7 +348,7 @@ static int scrc_local_out_common(struct osmo_sccp_instance *inst,
/* Called address includes SSN? */
if (called->presence & OSMO_SCCP_ADDR_T_SSN) {
- if (translate &&
+ if (/* TODO: check if we are doing global translation && */
(called->presence & OSMO_SCCP_ADDR_T_GT))
return scrc_translate_node_9(inst, xua, called);