diff options
authorNeels Hofmeyr <nhofmeyr@sysmocom.de>2017-06-26 04:49:57 +0200
committerNeels Hofmeyr <nhofmeyr@sysmocom.de>2017-06-27 21:25:03 +0000
commit81c0bcab068174036f6897e69311f413d94c74d4 (patch)
parent38d2aabd4a880dcdfa3a49dd8d83e2cfd30402ac (diff)
Revert "SCOC: When sending a CORE/CR, SUA SRC_ADDR == CallingPartyAddress"
This reverts commit 5527df78adc08b76df07c4b682263b5bdd6181d4. I tried some time to figure out what other changes are needed to make this commit work and fix a confusion, until I noticed: The commit's *log message* is correct that SRC == calling, but the *patch* modifies callED addr to be the SRC, which is wrong. So reverting this commit is indeed the correct way to fix our addresses. Change-Id: Ic76aacc81f87f8885fe04121aead5c79a761ef07
1 files changed, 1 insertions, 1 deletions
diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index 9502953..628b63b 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -483,7 +483,7 @@ static struct xua_msg *xua_gen_msg_co(struct sccp_connection *conn, uint32_t eve
xua_msg_add_u32(xua, SUA_IEI_ROUTE_CTX, conn->inst->route_ctx);
xua_msg_add_u32(xua, SUA_IEI_PROTO_CLASS, conn->sccp_class);
xua_msg_add_u32(xua, SUA_IEI_SRC_REF, conn->conn_id);
- xua_msg_add_sccp_addr(xua, SUA_IEI_SRC_ADDR, &conn->called_addr);
+ xua_msg_add_sccp_addr(xua, SUA_IEI_DEST_ADDR, &conn->called_addr);
xua_msg_add_u32(xua, SUA_IEI_SEQ_CTRL, 0); /* TODO */
/* optional: sequence number (class 3 only) */
if (conn->calling_addr.presence)