Update patch set 1

Patch Set 1: Code-Review+1 (2 comments) Patch-set: 1 Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1
2020-09-11 18:34:28 +00:00 · 2020-09-11 18:34:28 +00:00 · 58761c295d
parent b0369b1ef6
commit 58761c295d
1 changed files with 50 additions and 0 deletions
--- a/50
+++ b/50
@ -0,0 +1,50 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "1a7b4bb6_68fb86d1",
+        "filename": "src/ipa_proto.erl",
+        "patchSetId": 1
+      },
+      "lineNbr": 97,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2020-09-11T18:34:28Z",
+      "side": 1,
+      "message": "This looks like a public API, so we don\u0027t you -export() it?",
+      "range": {
+        "startLine": 97,
+        "startChar": 0,
+        "endLine": 97,
+        "endChar": 15
+      },
+      "revId": "bc59ec4f306d09cb1203f0d23dbd31efe46fbe01",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "ec491c12_fc57b98c",
+        "filename": "src/ipa_proto.erl",
+        "patchSetId": 1
+      },
+      "lineNbr": 257,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2020-09-11T18:34:28Z",
+      "side": 1,
+      "message": "Cosmetic: you could embed ipa_proto:request() call here:\n\n  case ipa_proto:request(Request) of\n    ...",
+      "range": {
+        "startLine": 257,
+        "startChar": 8,
+        "endLine": 257,
+        "endChar": 14
+      },
+      "revId": "bc59ec4f306d09cb1203f0d23dbd31efe46fbe01",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
+      "unresolved": true
+    }
+  ]
+}