erlang
/
osmo_ss7
mirror of https://gerrit.osmocom.org/erlang/osmo_ss7
4
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update patch set 2 

Patch Set 2: Code-Review+1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 53eb1bed089cbcd20cfe58801226a96be91e4bfe
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010 2024-02-28 17:24:12 +00:00 committed by Gerrit Code Review
parent b66838008e
commit 26ce651233
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
eef65b5b2ccaaeb2b2cf4b408889e892e5d92827 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "f2852495_6fd38ab6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-28T17:24:12Z",
"side": 1,
"message": "Would be nice to have some unit test coverage for this. Not blocking though.",
"revId": "eef65b5b2ccaaeb2b2cf4b408889e892e5d92827",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "de67f94a_5f9237c5",
"filename": "src/ipa_proto.erl",
"patchSetId": 2
},
"lineNbr": 189,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-28T17:24:12Z",
"side": 1,
"message": "cosmetic: please fix formatting here (nesting inside `case-of`)",
"revId": "eef65b5b2ccaaeb2b2cf4b408889e892e5d92827",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}